Fix CSV quoted-newline parsing + add valibot input validation to auth#29
Merged
Conversation
Single-pass CSV parser so newlines inside quoted fields no longer shred rows; auth /identify and /verify bodies validated via valibot (error responses byte-for-byte unchanged). Reviewed clean; CI green.
The /admin login landing was already linked from the landing page, but the CTA read "Open the dashboard" — not obviously a login to a sitter arriving cold. Relabel to "Sitter log in". Also correct the footer's "Open source" claim to "Self-hosted" since the app isn't strictly OSS. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
# Conflicts: # server/index.ts
bradburch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Merges the latest
mainintocustom-servicesand resolves the conflict. Net change landing onmain:server/lib/csv.ts— fix CSV parsing so a newline inside a quoted field stays one cell in one row (was splitting rows). Added test covering the quoted-newline case.server/routes/auth.ts— add valibot validation at the customer email-code auth trust boundary.valibot.Landing page note
This branch originally also relabeled the old landing CTA to "Sitter log in". That's now obsolete:
main(#26/#27/#28) rewrote the landing page and already ships a sitter login —<a href="/admin">Already set up? Sign in →</a>. The conflict was resolved by taking main's landing page verbatim and dropping the redundant edit.Verification
Local CI-equivalent all green:
typecheck,lint,format(tracked files),test,build.🤖 Generated with Claude Code