Skip to content
This repository was archived by the owner on Mar 17, 2026. It is now read-only.

Fix validation of element ids #353

Merged
srgzlb merged 5 commits into from
Dec 24, 2025
Merged

Fix validation of element ids #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f645246
fix validation of element ids
Dec 17, 2025
7089baa
Merge branch 'main' of github.com:booqable/chameleon-theme into fix/f…
Dec 23, 2025
d6c2487
Remove .tool-versions file
Dec 23, 2025
9898761
Fix double quotes in id attribute for images item
Dec 23, 2025
ac640c6
Add full width style for images items
Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .tool-versions
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions assets/critical.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,10 @@ img {
flex-direction: column;
}

.images__item {
width: 100%;
}

.images__text-area {
flex: 1 1 auto;
display: flex;
Expand Down
4 changes: 4 additions & 0 deletions assets/images.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
.images:not(:has(.carousel)) .block-frame .block-frame__buttons {
transform: translateX(-50%) !important;
}

.images__container--padding-top {
padding-top: var(--padding-top-mobile, 0);
}
Expand Down
1 change: 1 addition & 0 deletions assets/product-card.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
grid-template-rows: max-content 1fr;
position: relative;
min-width: 298px;
height: 100%;
overflow: clip;
border-radius: var(--border-radius-block-rounded);
contain: content;
Expand Down
18 changes: 7 additions & 11 deletions sections/images.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,14 +334,12 @@
{%- endif -%}
{% comment %} CSS variables end {% endcomment %}

{%- if carousel -%}
<div id="{{ block.id }}" class="carousel__item{% if effect == 'fade' and first == false %} hide{% endif %}{% if effect == 'fade' and first %} show{%- endif -%}" data-block-key="{{ block.id }}" data-block-name="{{ block.name }}"{% if show_overlay %} data-overlay-color="{{- overlay_color | escape -}}"{% endif %} aria-label="Slide {{ index }}">

<div class="images__item{% if carousel %} carousel__item{% if effect == 'fade' and first == false %} hide{% endif %}{% if effect == 'fade' and first %} show{%- endif -%}{%- endif -%}" id="{{- block.id -}}" data-block-key="{{- block.id -}}" data-block-name="{{- block.name -}}"{% if carousel %}{% if show_overlay %} data-overlay-color="{{- overlay_color | escape -}}"{% endif %} aria-label="Slide {{ index }}"{%- endif -%}>
{%- if carousel -%}
<div class="carousel__inner">
{%- else -%}
<div data-block-key="{{ block.id }}" data-block-name="{{ block.name }}">
{%- endif -%}
{%- endif -%}
<div
id="{{ block.id }}"
class="images__container container{% if padding_top != blank or padding_top_mobile != blank %} images__container--padding-top{% endif %}{% if padding_bottom != blank or padding_bottom_mobile != blank %} images__container--padding-bottom{% endif %}"
style="{{- text_variables | escape -}}"
>
Expand Down Expand Up @@ -412,12 +410,10 @@
{%- endif -%}
{%- endif -%}
</div>
{%- if carousel -%}
{%- if carousel -%}
</div>
</div>
{%- else -%}
</div>
{%- endif -%}
{%- endif -%}
</div>
{%- endfor -%}

{%- if carousel -%}
Expand Down
37 changes: 12 additions & 25 deletions sections/products.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,41 +122,28 @@
{%- for item in items limit: items_limit -%}
{%- assign index = forloop.index -%}

{% case items_type %}
{% when "blocks" %}
{% assign product = item.settings.product %}
{% when "collection" %}
{% assign product = item %}
{% endcase %}
{%- case items_type -%}
{%- when "blocks" -%}
{%- assign product = item.settings.product -%}
{%- assign id = item.id -%}
{%- when "collection" -%}
{%- assign product = item -%}
{%- assign id = product.id -%}
{%- endcase -%}

{%- if items_type == 'blocks' -%}
{% assign id = item.id %}
{%- else -%}
{% assign id = product.id %}
{%- endif -%}

{%- if carousel -%}
<div id="{{ id }}" class="carousel__item"{% if items_type == 'blocks' %} data-block-key="{{ item.id }}" data-block-name="{{ item.name }}"{% endif %} data-index="{{- index -}}" aria-label="Slide {{ index }}">
<div class="products__item{% if carousel %} carousel__item{%- endif -%}" id="{{- id -}}"{% if items_type == 'blocks' %} data-block-key="{{- item.id -}}" data-block-name="{{- item.name -}}"{% endif %}{% if carousel %} data-index="{{- index -}}" aria-label="Slide {{ index }}"{%- endif -%}>
{%- if carousel -%}
<div class="carousel__inner">
{%- else -%}
{%- if items_type == 'blocks' -%}
<div id="{{ id }}" data-block-key="{{ item.id }}" data-block-name="{{ item.name }}">
{%- endif -%}
{%- endif -%}
{%- render 'product-card',
block_id: id,
product: product,
settings: settings,
image_loading: loading_strategy
-%}
{%- if carousel -%}
</div>
</div>
{%- else -%}
{%- if items_type == 'blocks' -%}
{%- if carousel -%}
</div>
{%- endif -%}
{%- endif -%}
</div>
{%- endfor -%}

{%- if carousel -%}
Expand Down
18 changes: 7 additions & 11 deletions sections/testimonials.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,11 @@
{%- assign position = block.settings.position -%}
{%- assign stars = block.settings.stars -%}

{%- if carousel -%}
<div id="{{ block.id }}" class="carousel__item" data-block-key="{{ block.id }}" data-block-name="{{ block.name }}" data-index="{{- index -}}" aria-label="Slide {{ index }}">
<div class="testimonials__item{% if carousel %} carousel__item{%- endif -%}" id="{{- block.id -}}" data-block-key="{{- block.id -}}" data-block-name="{{- block.name -}}"{% if carousel %} data-index="{{- index -}}" aria-label="Slide {{ index }}"{%- endif -%}>
{%- if carousel -%}
<div class="carousel__inner">
{%- else -%}
<div data-block-key="{{ block.id }}" data-block-name="{{ block.name }}">
{%- endif -%}
<div id="{{ block.id }}" class="testimonials__content">
{%- endif -%}
<div class="testimonials__content">
{%- if title != blank or description != blank -%}
<div class="testimonials__col">
{%- if title != blank -%}
Expand Down Expand Up @@ -186,12 +184,10 @@
</div>
{%- endif -%}
</div>
{%- if carousel -%}
{%- if carousel -%}
</div>
</div>
{%- else -%}
</div>
{%- endif -%}
{%- endif -%}
</div>
{%- endfor -%}

{%- if carousel -%}
Expand Down
4 changes: 1 addition & 3 deletions snippets/product-card.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

{%- assign color_palette = settings.card_color_palette -%}
{%- assign excerpt = "" -%}
{%- assign id = "" -%}
{%- assign image = "" -%}
{%- assign image_bg = settings.card_image_background -%}
{%- assign image_fit = settings.card_image_fit -%}
Expand Down Expand Up @@ -51,7 +50,6 @@
{%- assign points = image.coordinates -%}
{%- endif -%}

{%- assign id = product.id -%}
{%- assign url = product.url -%}
{%- assign name = product.name -%}
{%- assign excerpt = product.excerpt -%}
Expand Down Expand Up @@ -82,7 +80,7 @@
{%- endcapture -%}
{% comment %} CSS variables end {% endcomment %}

<div id={{ block_id }} class="product-card{% if use_colors %} palette-{{ color_palette }}{%- endif -%}"{% if id != blank %} id="{{- id -}}"{% endif %} style="{{- card_variables | escape -}}">
<div class="product-card{% if use_colors %} palette-{{ color_palette }}{%- endif -%}" style="{{- card_variables | escape -}}">
<div class="product-card__vision{% if image_fit == 'contain' %}{% unless image_bg %} product-card__vision--white{% endunless %}{% endif %}{% unless image != blank %} no-image{%- endunless -%}">
{%- if image.url != blank -%}
{%- render 'image',
Expand Down