This repository was archived by the owner on Mar 17, 2026. It is now read-only.
Fix validation of element ids - #353
Merged
Merged
Conversation
JKinnez
self-requested a review
December 24, 2025 09:01
JKinnez
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors how IDs are assigned and used for carousel and non-carousel items across sections with products. It also streamlines the
product-cardsnippet to use the correct ID and variable names. The changes aim to prevent creating invalid HTML, duplicating or using incorrect IDs in the rendered HTML and to ensure that the correct data is passed to components.Also it solves this issue