feat: add PasswordField#203
Merged
Merged
Conversation
✅ Deploy Preview for storybook-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
9 tasks
emilyjablonski
requested changes
Jul 8, 2026
emilyjablonski
left a comment
emilyjablonski
left a comment
Collaborator
There was a problem hiding this comment.
Two small changes, otherwise looks great!
|
🎉 This PR is included in version 14.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
#6441
Description
There is Bloom PR ready using this component (so it might be reasonable to test it also there if it looks good on page)
Adds password field.
Just not sure if:
package.jsonchange is correct, as it seem to throw warning when testing*.stories.tsxfiles as in eslintrc we ignore "**/*.stories.tsx"How Can This Be Tested/Reviewed?
Check passwordField story
Checklist:
Reviewer Notes:
Steps to review a PR:
On merge, squash commits.