Skip to content

fix: add PasswordField from uic#6479

Open
KrissDrawing wants to merge 1 commit into
mainfrom
6442/Uptake-Password-UIC-Component
Open

fix: add PasswordField from uic#6479
KrissDrawing wants to merge 1 commit into
mainfrom
6442/Uptake-Password-UIC-Component

Conversation

@KrissDrawing

Copy link
Copy Markdown
Collaborator

This PR addresses #6442

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Technically i will need to merge This UI-C PR and upgrade it here. But i think it can be reviewed with that above pr.
It changes 2 password fields for one with show / hide password checkbox.

How Can This Be Tested/Reviewed?

switch to 6441/Password-UIC-Component branch on ui-c and then link it with current branch.
Then you can start testing

test those:
Sign-in (public and partners)
Create account (public)
Reset password (public and partners)
Account settings / change password (public) (also for advocates)
Partner confirm account (partners)

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@KrissDrawing KrissDrawing added the 1 review needed Requires 1 more review before ready to merge label Jul 7, 2026
@netlify

netlify Bot commented Jul 7, 2026

Copy link
Copy Markdown

Deploy Preview for bloom-angelopolis failed. Why did it fail? →

Name Link
🔨 Latest commit e286731
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/6a4d12f5527fdb00080a1f1b

@emilyjablonski

Copy link
Copy Markdown
Collaborator

I just merged the UIC PR, the new component is available in 14.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 review needed Requires 1 more review before ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants