Skip to content

Update de.json - #91

Merged
bikram-agarwal merged 12 commits into
bikram-agarwal:mainfrom
DwainZwerg:patch-1
Jun 25, 2026
Merged

bikram-agarwal merged 12 commits into
bikram-agarwal:mainfrom
DwainZwerg:patch-1

Conversation

@DwainZwerg

Copy link
Copy Markdown

add german translations

DwainZwerg and others added 4 commits June 16, 2026 11:01
add german translations
love text translation
add more strings (missing for whatever reason)
Comment thread assets/translations/de.json Outdated
Comment thread assets/translations/de.json
@bikram-agarwal
bikram-agarwal force-pushed the main branch 2 times, most recently from dd9c49b to 585942e Compare June 17, 2026 22:11

@bikram-agarwal bikram-agarwal left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: assets/translations/de.json:380 weakens googleVerificationWarningP3 compared with the English source. The current German text omits the important part that Google only promised an “advanced flow” after backlash and has not detailed how it works, so it is unclear whether it preserves user freedom in practice. That warning is policy/security-facing copy, so the translation should preserve the full meaning.

P3: assets/translations/de.json:535 has a visible typo: Ornder verwalten should be Ordner verwalten. This appears on the Manage Folders button via tr('manageFolders').

P3: assets/translations/de.json:473 has a visible typo: Priveligierte Apps überspringen. It should be Privilegierte Apps überspringen or similar. This is shown as the bulk scan filter label.

Resolved From Earlier Review

The old structural issues are fixed: rootPretendToBeGooglePlay is gone, reproducibleBuildEnforcedButBlocked is present, and placeholder parity now passes.

@bikram-agarwal

Copy link
Copy Markdown
Owner

and has not detailed how it works

That’s already been mentioned: https://android-developers.googleblog.com/2026/03/android-developer-verification.html, https://developer.android.com/blog/posts/android-developer-verification-rolling-out-to-all-developers-on-play-console-and-android-developer-console, https://android-developers.googleblog.com/2026/06/android-developer-verification.html, https://www.youtube.com/watch?v=WcPElxbOeXY

Good point. Google has published more detail about the advanced flow since this source string was written.

For this PR, please still keep the German translation aligned with the current English source string. If we want to update the actual warning text based on the newer Android docs, that should be done by changing en.json first or changing both en.json and de.json together in the same PR, so all locales keep the same meaning.

Also, there is a small typo in the current German text: reiter Kritik should be breiter Kritik.

Has nothing to do with riding, but with broad
Google has documented how the advanced flow works
@DwainZwerg

Copy link
Copy Markdown
Author

@bikram-agarwal That should be fixed now.

@bikram-agarwal bikram-agarwal left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bikram-agarwal
bikram-agarwal merged commit f5f33ac into bikram-agarwal:main Jun 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants