feat: Added Root Install method - #50
Open
0xBadCod3 wants to merge 16 commits into
Open
Conversation
Owner
|
Please run formatting before updating the PR. |
… installerPackageName
Comment on lines
+779
to
+786
| val writeToProcess = CompletableFuture.runAsync { | ||
| try { | ||
| file.inputStream().use { it.copyTo(process.outputStream) } | ||
| } finally { | ||
| runCatching { process.outputStream.close() } | ||
| } | ||
| process.waitFor() | ||
| } |
Owner
There was a problem hiding this comment.
This version fixes the previous cleanup/timeout concern. The one-shot subprocess design now looks much safer.
One remaining correctness issue: process.waitFor() is called, but its exit code is ignored. If pm install-write exits non-zero after consuming stdin, this block still completes successfully and the loop continues.
Please check the process exit code after writeToProcess.get(...) returns, and fail/abandon the session if it is non-zero. The error should include stdout/stderr so failed root installs are diagnosable.
bikram-agarwal
force-pushed
the
main
branch
4 times, most recently
from
June 17, 2026 22:11
dd9c49b to
585942e
Compare
Merged
bikram-agarwal
force-pushed
the
main
branch
3 times, most recently
from
July 10, 2026 07:31
688704e to
4f5a975
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds root installation support along with configuration for Google Play spoofing behavior.
The root install flow uses elevated shell commands through Root access.
libsurootPretendToBeGooglePlaysettingHere's a Demo:
Device: Xaga
Android: 16 AOSP
Root Granted using ReSukiSU
ScreenRecord.mp4