Skip to content

Refactor BSD os::rss and os::Bsd::get_process_uid #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snake66 merged 2 commits into from
Jul 14, 2026
Merged

Refactor BSD os::rss and os::Bsd::get_process_uid #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
581916b
Refactor BSD os::rss and os::Bsd::get_process_uid
snake66 Jul 2, 2026
de577e8
Remove unnecessary include of macros.hpp
snake66 Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 17 additions & 22 deletions src/hotspot/os/bsd/os_bsd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,17 @@ physical_memory_size_type os::Machine::physical_memory() {
return Bsd::physical_memory();
}

static int bsd_get_procinfo(pid_t pid, struct KINFO_PROC_T *kp, size_t *bufSize) {
int mib[] = {CTL_KERN, KERN_PROC_MIB, KERN_PROC_PID, pid,
# if !defined(__FreeBSD__) && !defined(__APPLE__)
static_cast<int>(*bufSize), 1
# endif
};
const u_int namelen = sizeof(mib)/sizeof(mib[0]);

return sysctl(mib, namelen, kp, bufSize, nullptr, 0);
}

size_t os::rss() {
size_t rss = 0;
#ifdef __APPLE__
Expand All @@ -366,19 +377,11 @@ size_t os::rss() {
rss = info.resident_size;
}
#else
pid_t pid = getpid();
struct KINFO_PROC_T kp;
size_t bufSize = sizeof kp;
#ifndef __FreeBSD__
u_int namelen = 6;
int mib[6] = {CTL_KERN, KERN_PROC_MIB, KERN_PROC_PID, pid,
static_cast<int>(bufSize), 1};
#else
u_int namelen = 4;
int mib[4] = {CTL_KERN, KERN_PROC, KERN_PROC_PID, pid};
#endif
if (sysctl(mib, namelen, &kp, &bufSize, nullptr, 0) != -1) {
return kp.KI_RSS * getpagesize();
size_t bufSize = sizeof(kp);

if (bsd_get_procinfo(getpid(), &kp, &bufSize) != -1) {
rss = kp.KI_RSS * getpagesize();
}
#endif // __APPLE__

Expand Down Expand Up @@ -1034,17 +1037,9 @@ pid_t os::Bsd::gettid() {

// Returns the uid of a process or -1 on error.
uid_t os::Bsd::get_process_uid(pid_t pid) {
struct KINFO_PROC_T kp;
struct kinfo_proc kp;
size_t size = sizeof kp;
#if defined(__FreeBSD__) || defined(__APPLE__)
u_int namelen = 4;
int mib_kern[4] = {CTL_KERN, KERN_PROC_MIB, KERN_PROC_PID, pid};
#else
u_int namelen = 6;
int mib_kern[6] = {CTL_KERN, KERN_PROC_MIB, KERN_PROC_PID, pid,
static_cast<int>(size), 1};
#endif
if (sysctl(mib_kern, namelen, &kp, &size, nullptr, 0) == 0) {
if (bsd_get_procinfo(pid, &kp, &size) == 0) {
if (size > 0 && kp.KI_PID == pid) {
return kp.KI_UID;
}
Expand Down
Loading