Refactor BSD os::rss and os::Bsd::get_process_uid - #66
Merged
snake66 merged 2 commits intoJul 14, 2026
Merged
Conversation
Moved the common sysctl call to a helper function `bsd_get_procinfo`, and simplified it a bit. This work is sponsored by The FreeBSD Foundation
This work is sponsored by The FreeBSD Foundation
bsdkurt
approved these changes
Jul 14, 2026
bsdkurt
left a comment
bsdkurt
left a comment
Collaborator
There was a problem hiding this comment.
Nice improvement and code reduction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the common sysctl call to a helper function
bsd_get_procinfo, and simplified it a bit.This work is sponsored by The FreeBSD Foundation