Fix/gateway dispatch admin route - #99
Conversation
- CompletableFuture.runAsync 제출 실패 시 outer try-catch 추가 (EventService, RelocationController) - RelocationController: RejectedExecutionException 발생 시 503 반환 - RestClient.Builder 빈 주입 방식으로 변경 (RelocationServiceClient, ControlServiceClient) - 좌표 키 'lng' → 'lon' 통일 (RelocationTriggerService) - DispatchServiceApplicationTests: Redis/Kafka 자동설정 제외 방식으로 변경 - SaveWeightServiceApplicationTests: test yml 기반으로 단순화
- DispatchServiceApplicationTests: spring.autoconfigure.exclude 제거 → test yml이 Redis/Kafka 커버 - RestClient.Builder.clone() 추가 (RelocationServiceClient, ControlServiceClient) — 공유 빌더 변경 부작용 방지 - RelocationTriggerService: 좌표 쌍 처리 chunked(2) 방식으로 가독성 개선
- KafkaConsumerConfig: concurrency를 KAFKA_DISPATCH_CONCURRENCY 환경변수로 제어 (기본값 4) - application.yml: staleness-threshold-seconds, kafka.dispatch.concurrency 환경변수 바인딩 추가 - 기본값: staleness 300초(5분), concurrency 4 (파티션 수와 일치)
…fix/gemini-review-only
block-internal-api에서 /dispatch/vehicles/*/active 제거 후 인증 없는 전용 어드민 라우트(dispatch-service-admin-vehicles-active)를 추가하여 baro-admin의 배차 정보 조회 복구
- TokenService: JWT어드민 role claim 포함 - AuthService: 토큰 발급 시 user.role 전달 - JwtAuthenticationGatewayFilterFactory: requiredRole Config 추가, FORBIDDEN 처리 - GatewayAuthenticationHeaders: X-Authenticated-Role 헤더 추가 - application.yml: dispatch/vehicles/*/active에 JwtAuthentication=ADMIN 적용
…fix/gateway-dispatch-admin-route
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to ignore Kafka messages in CarStateConsumer if they are older than 10 seconds, and configures the consumer's auto-offset-reset to latest. The reviewer correctly identified that the newly added producedAt parameter lacks a default value, which causes compilation failures in existing tests, and provided a code suggestion to resolve this issue.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| fun consume( | ||
| message: CarStateMessage, | ||
| @Header(name = KafkaHeaders.RECEIVED_KEY, required = false) carIdKey: String?, | ||
| @Header(KafkaHeaders.RECEIVED_TIMESTAMP) producedAt: Long, |
There was a problem hiding this comment.
The new producedAt parameter does not have a default value, which causes compilation errors in existing tests (such as CarStateConsumerTest.kt) where consume is called with only two arguments. Adding a default value like System.currentTimeMillis() will fix the compilation failure and ensure tests run successfully.
| @Header(KafkaHeaders.RECEIVED_TIMESTAMP) producedAt: Long, | |
| @Header(KafkaHeaders.RECEIVED_TIMESTAMP) producedAt: Long = System.currentTimeMillis(), |
1 participant
No description provided.