Fix arguments and paths for make_msa.sh - #148
Open
alephreish wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes several issues in how
make_msa.shis run frompreprocessing.py:database_params.sequencedbwhich in my interpretation was originally meant to provide the path to the database filesdatabase_params.commandsubprocess.run()is used inpreprocessing.py: it's a bad practice to create the entire command string by simply stitching together the command and the arguments.search_command = f"./{command} {fasta_file} {out_dir} {num_cpus} {ram_gb} {search_base} {template_database}"implied six arguments tomake_msa.shbut the script in fact expected five: this issue was masked by the fact thatsearch_base = model_runner.config.database_params.sequencedbis an empty string inbase.yaml.This commit does not fix several other issues in
make_msa.sh: e.g. it breaks if any of the paths have spaces.