Skip to content

Fix Mobile Chrome e2e failures on main after #353 #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
baba-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix Mobile Chrome e2e failures on main after #353 #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tests/e2e/kitchen-pro.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,16 @@ test("Kitchen Pro is scoped, responsive, and safely setup-only before commercial
await page.getByLabel("Password", { exact: true }).fill(f.password);
await page.getByRole("button", { name: "Sign in", exact: true }).click();
await expect(page).toHaveURL(/dashboard/);
await expect(page.getByRole("link", { name: "Kitchen Setup" })).toBeVisible();
// On phones Kitchen lives in the More sheet; on larger screens it is in the sidebar.
const more = page.getByRole("button", { name: "More" });
if (await more.isVisible()) {
await more.click();
await expect(
page.getByRole("dialog", { name: "More" }).getByRole("link", { name: "Kitchen Setup" })
).toBeVisible();
} else {
await expect(page.getByRole("link", { name: "Kitchen Setup" })).toBeVisible();
}
await page.goto("/kitchen");
// The modal is deliberately accessible and hides the underlying kitchen
// from the accessibility tree. Verify first-run onboarding before page content.
Expand Down
4 changes: 3 additions & 1 deletion tests/e2e/pos-till.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,9 @@ test("Point of Sale creates one canonical accepted staff order with one-tap entr
await expect(page.locator(".receipt-paper")).toContainText("Paneer Lunch");
await expect(page.locator(".receipt-details")).toContainText("+919876543210");
await expect(page.locator(".receipt-details dt").filter({ hasText: "Table" })).toHaveCount(0);
await expect(page.locator(".mm-workspace-sidebar")).toBeVisible();
// Phones hide the sidebar (bottom bar navigation); desktop shows it on screen.
if ((page.viewportSize()?.width ?? 0) > 900)
await expect(page.locator(".mm-workspace-sidebar")).toBeVisible();
await page.emulateMedia({ media: "print" });
await expect(page.locator(".mm-workspace-sidebar")).toBeHidden();
await expect(page.locator(".mm-shared-topbar")).toBeHidden();
Expand Down
Loading