Repository navigation
Conversation
… sidebar Kitchen Setup now lives in the More sheet on phones, and the sidebar is intentionally hidden on phones, so these assertions only apply on larger screens. Fixes the two Mobile Chrome failures on main after #353. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018caQbzEhmf9nMEnNbccatn
Owner
Author
|
CI note: Production Browser Shards 1/6 and 2/6 failed at the Playwright browser installation step ( Generated by Claude Code |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
CI on main after #353 (run 43029167300) failed in Production Browser Shard 5/6, which runs the Mobile Chrome project (PR CI runs chromium only, so this was not visible before merge). Two specs still assumed the old phone UI:
tests/e2e/kitchen-pro.spec.ts: expected the "Kitchen Setup" link on the dashboard after login. On phones Kitchen is now in the More sheet (bottom bar is Menus / QR Codes / Orders / Floor). The test opens More on phones and keeps the sidebar check elsewhere.tests/e2e/pos-till.spec.ts: expected.mm-workspace-sidebarvisible on screen before print emulation. The sidebar is intentionally hidden at <=900px when there is no outlet switcher; the visibility check now applies only above 900px. The print-media assertions are unchanged.Test-only change; no product code, migration or dependency changes.
Evidence
tsc --noEmitand prettier pass.Not verified / risks
Generated by Claude Code