Skip to content

Fix Mobile Chrome e2e failures on main after #353 - #354

Draft
baba-dev wants to merge 1 commit into
mainfrom
claude/intelligent-allen-h57c2e
Draft

baba-dev wants to merge 1 commit into
mainfrom
claude/intelligent-allen-h57c2e

Conversation

@baba-dev

Copy link
Copy Markdown
Owner

Behavior

CI on main after #353 (run 43029167300) failed in Production Browser Shard 5/6, which runs the Mobile Chrome project (PR CI runs chromium only, so this was not visible before merge). Two specs still assumed the old phone UI:

  • tests/e2e/kitchen-pro.spec.ts: expected the "Kitchen Setup" link on the dashboard after login. On phones Kitchen is now in the More sheet (bottom bar is Menus / QR Codes / Orders / Floor). The test opens More on phones and keeps the sidebar check elsewhere.
  • tests/e2e/pos-till.spec.ts: expected .mm-workspace-sidebar visible on screen before print emulation. The sidebar is intentionally hidden at <=900px when there is no outlet switcher; the visibility check now applies only above 900px. The print-media assertions are unchanged.

Test-only change; no product code, migration or dependency changes.

Evidence

  • tsc --noEmit and prettier pass.
  • Failure details taken from the CI logs of the failed shard (those were the only 2 failures; 80 other tests passed in that shard and all other lanes were green).

Not verified / risks

  • Could not run the Mobile Chrome specs locally (sandbox cannot bind the IPv6 SMTP fixture port). Mobile Chrome only runs on pushes to main, so the result is confirmed only after merge. The kitchen-pro test stopped at its first failing line, so later steps on mobile had not run in CI before; they do not touch the changed UI.

Generated by Claude Code

… sidebar

Kitchen Setup now lives in the More sheet on phones, and the sidebar is
intentionally hidden on phones, so these assertions only apply on larger
screens. Fixes the two Mobile Chrome failures on main after #353.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018caQbzEhmf9nMEnNbccatn

Copy link
Copy Markdown
Owner Author

CI note: Production Browser Shards 1/6 and 2/6 failed at the Playwright browser installation step (Installation process exited with code: 100) before any test ran, so these failures are not caused by this test-only diff. GitHub refuses a re-run while the workflow run is still in progress ("This workflow is already running"), so I'll re-run the failed jobs once the run finishes and keep watching until it is green.


Generated by Claude Code

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants