Skip to content

Mobile app first-review fixes: Google signup, nav, layouts, sign out - #353

Merged
baba-dev merged 4 commits into
mainfrom
claude/intelligent-allen-h57c2e
Nov 11, 2026
Merged

baba-dev merged 4 commits into
mainfrom
claude/intelligent-allen-h57c2e

Conversation

@baba-dev

Copy link
Copy Markdown
Owner

Behavior

  1. Google signup: /login Google button now requests sign-up with the disclosed current terms version (same payload as /register), so new Google users get an account. Added a terms/privacy disclosure under the button. Google callbacks route through /login, which sends users with outlets to next/overview and new users to /start -> onboarding. Name/email prefill the onboarding operations contact (empty drafts only).
  2. Landing: onboarding success and /app now land on /dashboard (overview). Checklist stays linked from overview.
  3. Bottom bar: Menus, QR Codes, Orders, Floor + More (icons unchanged: UtensilsCrossed, QrCode, ShoppingBag, Table2). Outlets without ordering back-fill with Overview/POS. POS/Kitchen moved to More.
  4. Logo header hidden at <=900px (sidebar kept when it holds the outlet switcher; hidden when empty).
  5. Kitchen Pro: Ember launcher row hidden on phones (kitchen header intact).
  6. Orders hero mobile height/type aligned with Dashboard (660px -> ~400-470px).
  7. POS full width: OperationalPwa rendered after TheTill and full-bleed selectors loosened (the installed-PWA aside broke the sibling selector).
  8. POS "Keep screen awake" hidden at <=900px (also applies to Kitchen, which has its own in-header toggle).
  9. Sign out added to the More sheet.

Migration / deploy

None. No schema or dependency changes. Not deployed.

Evidence

  • pnpm lint, pnpm typecheck: pass.
  • Vitest (local Postgres 16 + Redis): 1595 pass; 8 failures in demo-orders, double-billing.integration, infrastructure, reliable-jobs are identical on the untouched branch (local env roles/redis), not caused by this change.
  • New tests/login-google-signup.test.tsx; updated nav-model, shell-ui and e2e specs.

Not verified / risks

  • Playwright e2e specs were edited but not run here; next build not run. CI must confirm.
  • Layout items 4-8 are CSS and were not visually checked on a device; item 7's root cause (standalone PWA aside) is inferred.
  • Real Google sign-up needs operator confirmation: the deployed build must include Fix mobile onboarding: visible free signup and consent-gated Google registration #352, GOOGLE_CLIENT_ID/SECRET set, redirect URI https://food.bababuilds.com/api/auth/callback/google.

Generated by Claude Code

… overview

Login's Google button now requests sign-up with the disclosed current terms
and routes through /login (outlets -> overview, none -> onboarding).
Wizard and /app land on the dashboard overview. Google name/email prefill
the operations contact.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018caQbzEhmf9nMEnNbccatn
…in More, hide logo header

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018caQbzEhmf9nMEnNbccatn
…row and wake control on phones

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018caQbzEhmf9nMEnNbccatn
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018caQbzEhmf9nMEnNbccatn
@baba-dev

Copy link
Copy Markdown
Owner Author

Google Tester Phase 1 Review Acceptance

@baba-dev
baba-dev marked this pull request as ready for review November 11, 2026 13:26
@baba-dev
baba-dev merged commit bc2f8f7 into main Nov 11, 2026
21 checks passed
@baba-dev
baba-dev deleted the claude/intelligent-allen-h57c2e branch November 11, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants