Repository navigation
Fix mobile onboarding: visible free signup and consent-gated Google registration - #352
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Android TWA login showed the Create an account path only after the entire email/password form; new users often never see it. Existing Google OAuth was explicitly configured with
disableSignUp: true, making first-time Google onboarding impossible.Changes
next=/app.disableImplicitSignUp: true): registration page requires checked Terms/Privacy consent, sendsrequestSignUp: true, and receives server-stamped consent through Better Auth's server-only OAuth state.Deployment
Web-only changes, no DB migration and no Android binary changes. Production Google OAuth must be tested in Chrome TWA on a real Android device with a fresh Google identity and an existing linked Google identity. Verify configured Authorized redirect URI
https://food.bababuilds.com/api/auth/callback/google. Browser automation cannot complete live Google consent with CI fixtures.Safety
No implicit Google account linking, no TOTP bypass, no ID-token login, no external OAuth tokens in Android Java or log output.
Checklist