Skip to content

refactor(Core/Movement): Do a little cleanup for PointMovementGenerator.h #27114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PkllonG wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −5
Open

refactor(Core/Movement): Do a little cleanup for PointMovementGenerator.h #27114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f73136b
Update PointMovementGenerator.h
PkllonG Aug 13, 2026
7842284
Update PointMovementGenerator.h
PkllonG Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/server/game/Movement/MovementGenerators/PointMovementGenerator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ class PointMovementGenerator : public MovementGeneratorMedium< T, PointMovementG
{
public:
PointMovementGenerator(uint32 _id, float _x, float _y, float _z, ForcedMovement forcedMovement, float _speed = 0.0f, float orientation = 0.0f, Movement::PointsArray const* _path = nullptr,
bool generatePath = false, bool forceDestination = false, std::optional<AnimTier> animTier = std::nullopt, ObjectGuid chargeTargetGUID = ObjectGuid::Empty, bool reverseOrientation = false, ObjectGuid facingTargetGuid = ObjectGuid())
: id(_id), i_x(_x), i_y(_y), i_z(_z), speed(_speed), i_orientation(orientation), _generatePath(generatePath), _forceDestination(forceDestination), _reverseOrientation(reverseOrientation),
_chargeTargetGUID(chargeTargetGUID), _forcedMovement(forcedMovement), _facingTargetGuid(facingTargetGuid), _animTier(animTier)
bool generatePath = false, bool forceDestination = false, std::optional<AnimTier> animTier = std::nullopt, ObjectGuid chargeTargetGUID = ObjectGuid::Empty)
: id(_id), i_x(_x), i_y(_y), i_z(_z), speed(_speed), i_orientation(orientation), _generatePath(generatePath), _forceDestination(forceDestination),
_chargeTargetGUID(chargeTargetGUID), _forcedMovement(forcedMovement), _animTier(animTier)
{
if (_path)
m_precomputedPath = *_path;
Expand Down Expand Up @@ -61,10 +61,8 @@ class PointMovementGenerator : public MovementGeneratorMedium< T, PointMovementG
Movement::PointsArray m_precomputedPath;
bool _generatePath;
bool _forceDestination;
bool _reverseOrientation;
ObjectGuid _chargeTargetGUID;
ForcedMovement _forcedMovement;
ObjectGuid _facingTargetGuid;
std::optional<AnimTier> _animTier;
bool _stalled{};
bool _hasBeenStalled{};
Expand Down
Loading