Skip to content

refactor(Core/Movement): Do a little cleanup for PointMovementGenerator.h - #27114

Open
PkllonG wants to merge 2 commits into
azerothcore:masterfrom
PkllonG:PointMovementGenerator
Open

refactor(Core/Movement): Do a little cleanup for PointMovementGenerator.h#27114
PkllonG wants to merge 2 commits into
azerothcore:masterfrom
PkllonG:PointMovementGenerator

Conversation

@PkllonG

@PkllonG PkllonG commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

AI-assisted Pull Requests

Important

Using AI tools to prepare pull requests is allowed, but it must be disclosed and it must follow our AC guidelines for AI Agentic Engineering (link below).

You are expected to fully understand the changes you submit and to be able to explain and justify them when maintainers ask.

  • AI tools (e.g. Claude, ChatGPT, or similar) were used entirely or partially to prepare this pull request. If checked, specify which tools and models below.
    • Tools/models used:
  • I have read and understood the AC guidelines for AI Agentic Engineering

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. No need to test, as long as it builds successfully.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions Bot added CORE Related to the core file-cpp Used to trigger the matrix build labels Aug 13, 2026
@PkllonG PkllonG changed the title Update PointMovementGenerator.h refactor(Core/Movement): Do a little cleanup for PointMovementGenerator.h Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

PointMovementGenerator<T> no longer accepts reverseOrientation or facingTargetGuid constructor arguments. The corresponding private fields and member initializations were removed. Charge-target and forced-movement state remain unchanged.

Mergeability Score: 🔴 Critical · up to f7313

The constructor change currently contains an invalid initializer list, so the project cannot compile until the missing comma is added; the affected lines should also be wrapped to meet the repository’s formatting requirements.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9e201b41-24fa-4606-8996-4aa44435ff71

📥 Commits

Reviewing files that changed from the base of the PR and between 9ad2424 and f73136b.

📒 Files selected for processing (1)
  • src/server/game/Movement/MovementGenerators/PointMovementGenerator.h

Comment thread src/server/game/Movement/MovementGenerators/PointMovementGenerator.h Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE Related to the core file-cpp Used to trigger the matrix build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant