Update DynamoDB.Decoder to handle binary strings#61
Closed
gregggreg wants to merge 4 commits into
Closed
Conversation
Collaborator
|
Thank you @gregggreg |
sebsto
requested changes
Nov 7, 2024
sebsto
left a comment
sebsto
left a comment
Collaborator
There was a problem hiding this comment.
Looks good but I would like to add a unit test to cover this change
Collaborator
|
Hello @gregggreg |
Collaborator
|
Closing in favor of #103 |
sebsto
pushed a commit
that referenced
this pull request
Oct 22, 2025
…Event.Decoder (#103) Cleaned up version of [#61](#61) that also has tests. This PR makes it so that in lists, the decoder will not try to access the 0th index of an empty array. This PR will also make it so that `AttributeValue`s of type `.binary` will properly decode to base64 Strings when String is put as the type in the the `Decodable`. To avoid including `Data` in the code, I included code from the original source of the base 64 decoding methods (https://github.com/fabianfett/swift-base64-kit) to add in the corresponding encoding methods. However, I saw lots of Foundation is imported throughout so I reverted it. What are your thoughts on this matter? I also added tests that aim to make these failure points more resilient in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DynamoDBEvent.Decoder isn't currently handling the case where .binary attributes are base64encoded strings and throws an error
Motivation:
If you try to use DynamoDBEvent.Decoder on binary values, it throws an error saying it is expecting the value to be a string
Modifications:
Decoding string values now handles the case where they are .binary as well
Result:
If you have a DynamoDB record with binary values, you will be able to use DynamoDBEvent.Decoder to properly decode it without an error being thrown