Fixes and tests for decoding binary items and empty lists in DynamoDBEvent.Decoder#103
Merged
Conversation
…for base64 encoding code that does not require Data
Collaborator
|
Thank you Ben for submitting this.
Can we close that one in favor of this one ?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up version of #61 that also has tests.
This PR makes it so that in lists, the decoder will not try to access the 0th index of an empty array.
This PR will also make it so that
AttributeValues of type.binarywill properly decode to base64 Strings when String is put as the type in the theDecodable. To avoid includingDatain the code, I included code from the original source of the base 64 decoding methods (https://github.com/fabianfett/swift-base64-kit) to add in the corresponding encoding methods. However, I saw lots of Foundation is imported throughout so I reverted it. What are your thoughts on this matter?I also added tests that aim to make these failure points more resilient in the future.