-
Notifications
You must be signed in to change notification settings - Fork 47
CI/CD improvements #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azkrishpy
wants to merge
1
commit into
main
Choose a base branch
from
ci-cd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−0
Open
CI/CD improvements #302
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| name: Block needs-review merges | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened, labeled, unlabeled] | ||
|
|
||
| permissions: | ||
| pull-requests: read | ||
|
|
||
| jobs: | ||
| gate: | ||
| uses: awslabs/aws-crt-builder/.github/workflows/block-needs-review-label.yml@main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| name: Check ABI compliance | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
|
|
||
| concurrency: | ||
| group: check-abi-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| PACKAGE_NAME: aws-c-auth | ||
| CRT_CI_ROLE: ${{ secrets.CRT_CI_ROLE_ARN }} | ||
| AWS_DEFAULT_REGION: us-east-1 | ||
|
|
||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| check-abi: | ||
| name: check-abi | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - uses: aws-actions/configure-aws-credentials@v4 | ||
| with: | ||
| role-to-assume: ${{ env.CRT_CI_ROLE }} | ||
| aws-region: ${{ env.AWS_DEFAULT_REGION }} | ||
|
|
||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Check ABI | ||
| uses: awslabs/aws-crt-builder/.github/actions/check-abi@main | ||
| with: | ||
| lib-name: ${{ env.PACKAGE_NAME }} | ||
| builder-version: latest | ||
| builder-source: releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: Release | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| dry-run: | ||
| description: 'Compute and summarize the bump/version but do not commit, tag, or publish anything.' | ||
| required: false | ||
| default: 'false' | ||
|
|
||
| env: | ||
| PACKAGE_NAME: aws-c-auth | ||
| CRT_CI_ROLE: ${{ secrets.CRT_CI_ROLE_ARN }} | ||
| AWS_DEFAULT_REGION: us-east-1 | ||
|
|
||
| permissions: | ||
| id-token: write | ||
| contents: write | ||
| pull-requests: read | ||
|
|
||
| jobs: | ||
| release: | ||
| name: release | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - uses: aws-actions/configure-aws-credentials@v4 | ||
| with: | ||
| role-to-assume: ${{ env.CRT_CI_ROLE }} | ||
| aws-region: ${{ env.AWS_DEFAULT_REGION }} | ||
|
|
||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Release | ||
| uses: awslabs/aws-crt-builder/.github/actions/auto-release@main | ||
| with: | ||
| lib-name: ${{ env.PACKAGE_NAME }} | ||
| dry-run: ${{ inputs.dry-run }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 0.10.3 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
somewhere, we need to document this.
Will it be a concern if multiple developer try to kick off the action?
can we do something to prevent the action to run when there is another one in progress?
the abi check will take time, and it needs to build the package, right?
What if the build fails or some random failure goes on (eg: pull deps fails)?
How will the dev find it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a guidance doc available for cutting releases. Will update it with some last minute stuff but the core idea already of auto releases already exists.
Worst case scenario is two people try to run release at the same time, one person commits to main first and the other person's commit fails since we don't force push the branch. They would have to restart release.
ref: https://github.com/awslabs/aws-crt-builder/blob/0cb166b3cb3f3cee1b61e5139919e7d3a2adca51/.github/actions/auto-release/scripts/cut-release.sh#L94
Release job provides logs: https://github.com/awslabs/aws-c-common/actions/runs/31543641609
the abi-check action uses the builder package to build, so if the CI passes, we should not really have any issues building for the ABI check. (https://github.com/awslabs/aws-crt-builder/blob/0cb166b3cb3f3cee1b61e5139919e7d3a2adca51/.github/actions/check-abi/scripts/build.sh#L91).
If the ABI check fails, the release fails and the dev would have to look through the logs to investigate.