Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
=======================================
Coverage 81.91% 81.91%
=======================================
Files 36 36
Lines 7144 7144
=======================================
Hits 5852 5852
Misses 1292 1292 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
somewhere, we need to document this.
Will it be a concern if multiple developer try to kick off the action?
can we do something to prevent the action to run when there is another one in progress?
the abi check will take time, and it needs to build the package, right?
What if the build fails or some random failure goes on (eg: pull deps fails)?
How will the dev find it out?
There was a problem hiding this comment.
somewhere, we need to document this.
There is a guidance doc available for cutting releases. Will update it with some last minute stuff but the core idea already of auto releases already exists.
Will it be a concern if multiple developer try to kick off the action?
Worst case scenario is two people try to run release at the same time, one person commits to main first and the other person's commit fails since we don't force push the branch. They would have to restart release.
the abi check will take time, and it needs to build the package, right?
What if the build fails or some random failure goes on (eg: pull deps fails)?
How will the dev find it out?
Release job provides logs: https://github.com/awslabs/aws-c-common/actions/runs/31543641609
the abi-check action uses the builder package to build, so if the CI passes, we should not really have any issues building for the ABI check. (https://github.com/awslabs/aws-crt-builder/blob/0cb166b3cb3f3cee1b61e5139919e7d3a2adca51/.github/actions/check-abi/scripts/build.sh#L91).
If the ABI check fails, the release fails and the dev would have to look through the logs to investigate.
3 participants
Issue #, if available:
N/A
Description of changes:
Adds CI/CD workflows mirroring awslabs/aws-c-common#1250:
check-abi.yml— ABI compliance check on PRsrelease.yml— manual (workflow_dispatch) release with auto version bump + tagblock-needs-review.yml— gate merges labeledneeds-reviewVERSIONfile seeded from latest release tagVERSIONfromVERSIONfile viaaws_get_version()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.