chore(e2e): add CustomerProfilesPushApp to the detox E2E matrix - #14907
chore(e2e): add CustomerProfilesPushApp to the detox E2E matrix#14907soberm wants to merge 6 commits into
Conversation
Adds the React Native CustomerProfilesPushApp sample (aws-amplify/amplify-js-samples-staging#1127) to the detox E2E matrix and enables the push integ test workflow for this branch.
|
… artifacts Scopes the push trigger to a single detox run instead of the full release-verification matrix, and uploads Detox artifacts/reports so failures can be inspected.
Restores .github/workflows/push-integ-test.yml and .github/workflows/callable-e2e-test-detox.yml to their state on main, leaving only the detox-integ-all.yml matrix entry in this PR. The push trigger and artifact upload were temporary scaffolding used to verify the new test.
osama-rizk
left a comment
There was a problem hiding this comment.
Reviewed the detox matrix addition. The YAML itself is correct and idiomatic: the entry matches every sibling's convention — integ_rn_ios_* naming, the amplify-js-samples-staging/samples/react-native/<category>/<App> path shape, timeout_minutes: 120, and it parses cleanly into the matrix that callable-e2e-tests.yml loads. No issues with the change as written.
The whole risk on a CI-config change like this is external-reference validity and merge ordering, not syntax — so that's where I looked, and there's one thing worth confirming before merge (inline). Everything else checks out: I traced how the config is consumed (callable-e2e-tests.yml → callable-e2e-test-detox.yml, gated behind the run-tests label via pr-label.yml) and how the samples repo is resolved (setup-samples-staging), and both behave as the entry assumes.
Description of changes
Adds the
CustomerProfilesPushAppReact Native sample from aws-amplify/amplify-js-samples-staging#1127 to the Detox E2E matrix (.github/integ-config/detox-integ-all.yml).Issue #, if available
Description of how you validated changes
Verified the sample path against the staging PR and that the YAML parses into the expected matrix entry.
Verification: the new test ran green on the iOS simulator — E2E-Detox integ_rn_ios_push_notifications_customer_profiles:
Tests: 11 passed, 11 total(fullCustomerProfilesPushAppdetox suite).Checklist
yarn testpasses — not run; CI config only, no library source touchedChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.