Skip to content

chore(e2e): add CustomerProfilesPushApp to the detox E2E matrix - #14907

Open
soberm wants to merge 6 commits into
mainfrom
chore/push-notifications-tests
Open

chore(e2e): add CustomerProfilesPushApp to the detox E2E matrix#14907
soberm wants to merge 6 commits into
mainfrom
chore/push-notifications-tests

Conversation

@soberm

@soberm soberm commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Adds the CustomerProfilesPushApp React Native sample from aws-amplify/amplify-js-samples-staging#1127 to the Detox E2E matrix (.github/integ-config/detox-integ-all.yml).

Issue #, if available

Description of how you validated changes

Verified the sample path against the staging PR and that the YAML parses into the expected matrix entry.

Verification: the new test ran green on the iOS simulator — E2E-Detox integ_rn_ios_push_notifications_customer_profiles: Tests: 11 passed, 11 total (full CustomerProfilesPushApp detox suite).

Checklist

  • PR description included
  • yarn test passes — not run; CI config only, no library source touched
  • Unit Tests are changed or added — n/a, test logic lives in the samples repo
  • Relevant documentation is changed or added — n/a

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows — new test verified green (11/11), see Verification above
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate — n/a, no new source paths

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds the React Native CustomerProfilesPushApp sample (aws-amplify/amplify-js-samples-staging#1127)
to the detox E2E matrix and enables the push integ test workflow for this branch.
@soberm
soberm requested a review from a team as a code owner August 6, 2026 11:01
@changeset-bot

changeset-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b100508

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

soberm added 5 commits August 6, 2026 12:26
… artifacts

Scopes the push trigger to a single detox run instead of the full
release-verification matrix, and uploads Detox artifacts/reports so failures
can be inspected.
Restores .github/workflows/push-integ-test.yml and
.github/workflows/callable-e2e-test-detox.yml to their state on main, leaving
only the detox-integ-all.yml matrix entry in this PR. The push trigger and
artifact upload were temporary scaffolding used to verify the new test.

@osama-rizk osama-rizk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the detox matrix addition. The YAML itself is correct and idiomatic: the entry matches every sibling's convention — integ_rn_ios_* naming, the amplify-js-samples-staging/samples/react-native/<category>/<App> path shape, timeout_minutes: 120, and it parses cleanly into the matrix that callable-e2e-tests.yml loads. No issues with the change as written.

The whole risk on a CI-config change like this is external-reference validity and merge ordering, not syntax — so that's where I looked, and there's one thing worth confirming before merge (inline). Everything else checks out: I traced how the config is consumed (callable-e2e-tests.ymlcallable-e2e-test-detox.yml, gated behind the run-tests label via pr-label.yml) and how the samples repo is resolved (setup-samples-staging), and both behave as the entry assumes.

Comment thread .github/integ-config/detox-integ-all.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants