Skip to content

chore(e2e): add CustomerProfilesPushApp to the detox E2E matrix - #14906

Closed
soberm wants to merge 1 commit into
aws-amplify:mainfrom
soberm:chore/push-notifications-tests
Closed

chore(e2e): add CustomerProfilesPushApp to the detox E2E matrix#14906
soberm wants to merge 1 commit into
aws-amplify:mainfrom
soberm:chore/push-notifications-tests

Conversation

@soberm

@soberm soberm commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Adds the CustomerProfilesPushApp React Native sample from aws-amplify/amplify-js-samples-staging#1127 to the Detox E2E matrix (.github/integ-config/detox-integ-all.yml).

This branch is named to match the staging PR branch (chore/push-notifications-tests) so setup-samples-staging checks out the right sample app, and push-integ-test.yml points at this branch so the run shows up here.

Issue #, if available

aws-amplify/amplify-js-samples-staging#1127

Description of how you validated changes

Verified the sample path against the staging PR and that both changed YAML files parse into the expected matrix entry and branch filter.

Checklist

  • PR description included
  • yarn test passes — not run; CI config only, no library source touched
  • Unit Tests are changed or added — n/a, test logic lives in the samples repo
  • Relevant documentation is changed or added — n/a

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows — needs a run from upstream; fork runs can't access GH_TOKEN_STAGING_READ
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate — n/a, no new source paths

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds the React Native CustomerProfilesPushApp sample (aws-amplify/amplify-js-samples-staging#1127)
to the detox E2E matrix and enables the push integ test workflow for this branch.
@soberm
soberm requested a review from a team as a code owner August 6, 2026 09:44
@changeset-bot

changeset-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1b002ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@soberm

soberm commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #14907. Closing this one: it was opened from my fork, so the E2E workflow couldn't access GH_TOKEN_STAGING_READ (needed by setup-samples-staging) and the push-integ-test.yml push trigger never fired upstream. #14907 has the identical commit on a branch pushed directly to this repo, so the integ tests run with secrets available.

@soberm soberm closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant