security: clear RUSTSEC findings and Ferriskey Clippy failures - #534
Merged
Conversation
…spin) cargo audit --deny warnings was failing on main with 3 denied warnings, which blocked the cargo-group Dependabot PR (#531) carrying the quinn-proto security bump. Resolves all four in one lockfile update: quinn-proto 0.11.14 -> 0.11.16 RUSTSEC-2026-0185 (7.5 high) remote memory exhaustion via unbounded out-of-order stream reassembly — the actual vulnerability, superset of #531 anyhow 1.0.102 -> 1.0.104 RUSTSEC-2026-0190 (unsound) unsoundness in Error::downcast_mut(); patched >= 1.0.103 scc 2.4.0 -> removed RUSTSEC-2026-0205 (unsound) Array::insert exception-safety / potential double-free. Reached only as a dev-dependency via serial_test 3.4; serial_test 3.5.0 drops the scc dependency entirely, so no major bump is needed (scc's own fix is 3.8.4, a major jump). spin 0.9.8 -> 0.9.9 yanked-crate warning transitive under sqlx-sqlite -> flume; 0.9.9 is not yanked. Lockfile only — no manifest ranges changed, no majors introduced, and no new entries added to the .cargo/audit.toml / deny.toml ignore lists. Verified: cargo audit --deny warnings exits 0 (468 deps scanned, zero findings); cargo check --workspace --all-targets succeeds.
cargo clippy -D warnings fails on main in the ferriskey lib, which takes
down all three clippy invocations in matrix.yml / release.yml (the scoped
workspace job compiles ferriskey as a dependency, so it fails there too)
and with it every `valkey N · standalone|cluster` matrix leg.
cluster/routing.rs:552 clippy::for_kv_map
`for (_, arg_indices) in routes.iter_mut()` -> `routes.values_mut()`
cmd.rs:74 clippy::question_mark
collapse the if-let/else-return into `self.cmd.cursor?`; next_item
already returns Option<T> and uses `?` further down, so this is the
idiom the surrounding code already follows
Pre-existing debt, not a regression: verified identical failures on a
clean checkout of main at 0def596 with no local changes.
Verified all three CI clippy invocations now exit 0:
cargo clippy -p ff-core -p ff-script -p ff-engine -p ff-scheduler \
-p ff-sdk -p ff-server -p ff-test -p ff-backend-sqlite \
--features ff-sdk/direct-valkey-claim -- -D warnings
cargo clippy -p ferriskey --all-targets -- -D warnings
cargo clippy -p ferriskey --all-targets --features iam -- -D warnings
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Supersedes #532 and #533 by combining both fixes into one branch.