fix(ferriskey): clear two clippy lib errors blocking every matrix job - #533
Closed
avifenesh wants to merge 1 commit into
Closed
fix(ferriskey): clear two clippy lib errors blocking every matrix job#533avifenesh wants to merge 1 commit into
avifenesh wants to merge 1 commit into
Conversation
cargo clippy -D warnings fails on main in the ferriskey lib, which takes
down all three clippy invocations in matrix.yml / release.yml (the scoped
workspace job compiles ferriskey as a dependency, so it fails there too)
and with it every `valkey N · standalone|cluster` matrix leg.
cluster/routing.rs:552 clippy::for_kv_map
`for (_, arg_indices) in routes.iter_mut()` -> `routes.values_mut()`
cmd.rs:74 clippy::question_mark
collapse the if-let/else-return into `self.cmd.cursor?`; next_item
already returns Option<T> and uses `?` further down, so this is the
idiom the surrounding code already follows
Pre-existing debt, not a regression: verified identical failures on a
clean checkout of main at 0def596 with no local changes.
Verified all three CI clippy invocations now exit 0:
cargo clippy -p ff-core -p ff-script -p ff-engine -p ff-scheduler \
-p ff-sdk -p ff-server -p ff-test -p ff-backend-sqlite \
--features ff-sdk/direct-valkey-claim -- -D warnings
cargo clippy -p ferriskey --all-targets -- -D warnings
cargo clippy -p ferriskey --all-targets --features iam -- -D warnings
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This was referenced Jul 30, 2026
Owner
Author
|
Absorbed into #534 alongside the security lockfile update, avoiding a merge with known baseline audit failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo clippy -- -D warningsfails onmaininside the vendoredferriskeylib. Because the scoped workspace clippy job compilesferriskeyas a dependency, all three clippy invocations fail — and with them everyvalkey N · standalone|clustermatrix leg.ferriskey/src/cluster/routing.rs:552clippy::for_kv_mapfor (_, arg_indices) in routes.iter_mut()→routes.values_mut()ferriskey/src/cmd.rs:74clippy::question_markself.cmd.cursor?The
cmd.rschange is the idiom the surrounding code already uses —next_itemreturnsOption<T>and calls?on the next two lines, so this is consistent rather than a new style.Pre-existing, not a regression
Verified on a clean checkout of
main@0def596with zero local changes — identical two errors. This debt is what's been failing the matrix; it isn't introduced by any dependency PR.Verification — all three CI clippy invocations now exit 0
Scope note
Two files, 3 insertions / 6 deletions. Deliberately not bundled with #532 (the RUSTSEC lockfile sweep) so the security fix stays reviewable as a lockfile-only diff.
While confirming this I also found ~35 further clippy errors in test files (
result_large_errinparity_stage_c/d1,needless_range_loopacrossflow_edge_policies_stage_*). Those are invisible to CI today because the scoped clippy job runs without--all-targets— onlyferriskeygets the all-targets treatment. Left out of this PR; worth a separate cleanup pass, and possibly worth deciding whether the workspace job should gain--all-targetsto stop that drift recurring.