Skip to content

fix(ferriskey): clear two clippy lib errors blocking every matrix job - #533

Closed
avifenesh wants to merge 1 commit into
mainfrom
chore/ferriskey-clippy-lib
Closed

fix(ferriskey): clear two clippy lib errors blocking every matrix job#533
avifenesh wants to merge 1 commit into
mainfrom
chore/ferriskey-clippy-lib

Conversation

@avifenesh

Copy link
Copy Markdown
Owner

Summary

cargo clippy -- -D warnings fails on main inside the vendored ferriskey lib. Because the scoped workspace clippy job compiles ferriskey as a dependency, all three clippy invocations fail — and with them every valkey N · standalone|cluster matrix leg.

Location Lint Fix
ferriskey/src/cluster/routing.rs:552 clippy::for_kv_map for (_, arg_indices) in routes.iter_mut()routes.values_mut()
ferriskey/src/cmd.rs:74 clippy::question_mark collapse if-let/else-return into self.cmd.cursor?

The cmd.rs change is the idiom the surrounding code already uses — next_item returns Option<T> and calls ? on the next two lines, so this is consistent rather than a new style.

Pre-existing, not a regression

Verified on a clean checkout of main @ 0def596 with zero local changes — identical two errors. This debt is what's been failing the matrix; it isn't introduced by any dependency PR.

Verification — all three CI clippy invocations now exit 0

cargo clippy -p ff-core -p ff-script -p ff-engine -p ff-scheduler \
  -p ff-sdk -p ff-server -p ff-test -p ff-backend-sqlite \
  --features ff-sdk/direct-valkey-claim -- -D warnings   # exit 0
cargo clippy -p ferriskey --all-targets -- -D warnings              # exit 0
cargo clippy -p ferriskey --all-targets --features iam -- -D warnings  # exit 0

Scope note

Two files, 3 insertions / 6 deletions. Deliberately not bundled with #532 (the RUSTSEC lockfile sweep) so the security fix stays reviewable as a lockfile-only diff.

While confirming this I also found ~35 further clippy errors in test files (result_large_err in parity_stage_c/d1, needless_range_loop across flow_edge_policies_stage_*). Those are invisible to CI today because the scoped clippy job runs without --all-targets — only ferriskey gets the all-targets treatment. Left out of this PR; worth a separate cleanup pass, and possibly worth deciding whether the workspace job should gain --all-targets to stop that drift recurring.

cargo clippy -D warnings fails on main in the ferriskey lib, which takes
down all three clippy invocations in matrix.yml / release.yml (the scoped
workspace job compiles ferriskey as a dependency, so it fails there too)
and with it every `valkey N · standalone|cluster` matrix leg.

  cluster/routing.rs:552  clippy::for_kv_map
      `for (_, arg_indices) in routes.iter_mut()` -> `routes.values_mut()`
  cmd.rs:74               clippy::question_mark
      collapse the if-let/else-return into `self.cmd.cursor?`; next_item
      already returns Option<T> and uses `?` further down, so this is the
      idiom the surrounding code already follows

Pre-existing debt, not a regression: verified identical failures on a
clean checkout of main at 0def596 with no local changes.

Verified all three CI clippy invocations now exit 0:
  cargo clippy -p ff-core -p ff-script -p ff-engine -p ff-scheduler \
    -p ff-sdk -p ff-server -p ff-test -p ff-backend-sqlite \
    --features ff-sdk/direct-valkey-claim -- -D warnings
  cargo clippy -p ferriskey --all-targets -- -D warnings
  cargo clippy -p ferriskey --all-targets --features iam -- -D warnings
Copilot AI review requested due to automatic review settings July 29, 2026 06:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@avifenesh

Copy link
Copy Markdown
Owner Author

Absorbed into #534 alongside the security lockfile update, avoiding a merge with known baseline audit failures.

@avifenesh avifenesh closed this Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants