Conversation
Consistently return QueryResult instead of specialized types from search and browse requests.
Introduce base interfaces for lookup, search and browse requests.
Introduce base LookupService class and remove specialized WorkService.
Introduce base IEntity interface to mark data classes that support lookup, search or browse.
Remove specialized entity collections namespace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors a few aspects of the services and introduces a breaking change to the public API:
QueryResult<T>instead of specialized types from search and browse requests.LookupServiceclass and remove specializedWorkService.IEntityinterface to mark data classes that support lookup, search or browse.Hqub.MusicBrainz.Entities.Collections.Returning
QueryResult<T>from search and browse requests should not affect user code unless the returned collection types were explicitly used, for exampleMerging this will require a major version update of the library.