Thoughts on Label Country lookup?

[arsinclair]

Currently if label area is set to a city, there's no way to return the country information, MusicBrainz doesn't supply it. What could work and I saw someone recommending it on some forums, is to walk up the area tree from the city location to the country location and get the country.

Is this something that we're interested doing inside of this library? If yes, I already have a working code and I can contribute it here, making it possible for me to entirely migrate my own projects towards this library.

If not, I will also understand it. After all, such lookup is a bit more than just a set of bindings over the REST API, which is what this library currently is.

[wo80]

Thanks for the suggestion, this would be another welcome addition.

I think the only missing part is support for area-rels, so adding a property for this subquery to the Relation class should be enough. It's then up to the user to inspect the relation content (example Berlin), looking for

• relation target-type: "area"
• relation type: "part of"
• relation direction: "backward"

If there's an area with area.type == "country" in the list you're done, otherwise repeat with a new area candidate.

But that code should not be part of the library. Maybe worth writing a separate example for this.

[arsinclair]

Okay, I will work on adding the Area service then and the necessary relationships.

[wo80]

If you plan to only implement the lookup functionality for the Area service (which should be enough imho), you can take the IWorkService as a blueprint.

[wo80]

I have opened a PR #82 updating the test project. I'd suggest to merge this directly after #81 to avoid conflicts, in case you are planning to write unit tests for the Area service.

[arsinclair]

Okay, sounds good. I'll wait until #82 is merged before doing anything.

[wo80]

The test project already has area-get.json data (the Berlin example from above). You can look at WorkGetTests.cs to see how I implemented the unit tests.

[wo80]

Currently working on #83 and will probably do a PR to close this issue tomorrow.

[arsinclair]

Thank you, I just had a glance through the PR and the changes make sense to me.

[wo80]

Please take a look at #84 and let me know whether you think there's anything missing.

[arsinclair]

The PR looks good to me. Thank you for adding it!

I will wait until you release a new version and then upgrade it in my workflows. If anything is missing, I'll then open a PR to add it :)