This repository was archived by the owner on Dec 16, 2025. It is now read-only.
style: remaining NPM conversion cleanup items - #1910
Open
JonathanOppenheimer wants to merge 11 commits into
Open
style: remaining NPM conversion cleanup items#1910JonathanOppenheimer wants to merge 11 commits into
JonathanOppenheimer wants to merge 11 commits into
Conversation
JonathanOppenheimer
changed the base branch from
master
to
JonathanOppenheimer/delete-npm
December 5, 2025 20:13
JonathanOppenheimer
added
the
DO NOT MERGE
20 tasks
maru-ava
removed their request for review
December 8, 2025 16:06
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/delete-npm
branch
from
December 8, 2025 20:26
5ce8045 to
b11a074
Compare
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/remaining-conversion-cleanup
branch
from
December 8, 2025 20:55
1f58bb6 to
3c6ed99
Compare
alarso16
approved these changes
Dec 9, 2025
alarso16
left a comment
alarso16
left a comment
Contributor
There was a problem hiding this comment.
I don't see the point in unifying style whitespace if it won't be enforced by anything. It really doesn't matter, so I'll approve
JonathanOppenheimer
changed the title
JonathanOppenheimer
changed the base branch from
JonathanOppenheimer/delete-npm
to
JonathanOppenheimer/use-new-abi
December 10, 2025 20:59
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/remaining-conversion-cleanup
branch
from
December 11, 2025 23:07
e097dd3 to
bd17da5
Compare
JonathanOppenheimer
force-pushed
the
JonathanOppenheimer/remaining-conversion-cleanup
branch
from
December 11, 2025 23:11
4259b4a to
0d975ca
Compare
…er/remaining-conversion-cleanup
…er/remaining-conversion-cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
There were a couple clean up items I made in the past series of PRs that should be broken out into a separate PR (this one).
This PR
.abifiles tocontract.gogenesis.jsonoutside of genesis folder -- after refactors, each of these folders only had a single item, which is silly.How this was tested
There are no functional changes in this PR
Need to be documented?
No
Need to update RELEASES.md?
No