Epic: Subnet-EVM code readiness for monorepo

[JonathanOppenheimer]

The following PRs must be merged (or resolved in another manner), prior to subnet-evm being ready for the monorepo.

The below is the category of fix, and the PRs associated with it. Any and all reviews are appreciated!

Tests:

• Flaky tests Epic: fix flaky EVM tests #4558
  • This is historically optional, as a lot of these flaky tests were introduced into AvalancheGo (through graft/coreth) without resolution.
• Skip filters test sync: coreth PR #1404: ci: Filters test corrections subnet-evm#1889
• Do not retry tests ci: Remove test retries subnet-evm#1877

Build:

• Remove go run x in favor of tooling sync: coreth PR #1407 build: remove unneeded dependencies subnet-evm#1888
• Remove dead t8n code chore: remove dead t8n code subnet-evm#1901
• Update Subnet-EVM to latest AvalancheGo version chore: Update AvalancheGo version subnet-evm#1896

Linting:

• Links linter sync: coreth PR #1392: chore: Add lint link check job subnet-evm#1870
• forbidigo sync: coreth PR #1303 style: Use require.ErrorIs whenever possible subnet-evm#1875
• Remove old unpack code chore: remove old pack/unpack code subnet-evm#1903
  • This is not critical, but resolves a linting / style concern that @alarso16 had. Right now the resultant code is nolinted
• errcheck sync: coreth PR #1203: style: enable errcheck linter subnet-evm#1876
• depguard sync: coreth PR #1271: style: enable depguard linter subnet-evm#1886
• License headers sync: coreth PR #1424: fix license header subnet-evm#1891

Precompile test rewrites:

• move interfaces out of test directory test: move precompile interfaces out of test directory  subnet-evm#1913
• tx allowlist feat: convert tx allow list npm test to go test subnet-evm#1897
• fee manager feat: convert fee manager npm test to go test subnet-evm#1885
• reward manager feat: convert tx reward manager npm test to go test subnet-evm#1900
• warp test: convert warp npm test to go test subnet-evm#1907
• npm removal feat: remove npm directory and npm test framework subnet-evm#1914
• use generated abi test: use generated ABI #4740
• final clean up style: remaining NPM conversion cleanup items #4780
  • This PR is purely stylistic, and optional for the monorepo (it can be done after)

[ceyonur]

Can we also add a task to move the contracts npm package to a separate repository under subnet-evm-precompile-examples etc and archive/make readonly that repo? We should be picking a revision at the time there was no binding and where the folder was a pure hardhat/npm package. cc @JonathanOppenheimer

[JonathanOppenheimer]

Can we also add a task to move the contracts npm package to a separate repository under subnet-evm-precompile-examples etc and archive/make readonly that repo? We should be picking a revision at the time there was no binding and where the folder was a pure hardhat/npm package. cc @JonathanOppenheimer

We certainly can, but from talking Arran, he expressed that he saw little utility in doing so (creating an examples repository that is). Is this still something desired?

[ceyonur]

We certainly can, but from talking Arran, he expressed that he saw little utility in doing so (creating an examples repository that is). Is this still something desired?

I don't see any harm doing that as we won't maintain that repository. So even if there is a slight potential that it can be useful for developers I'd say its benefit overweights the cost.

It's also a npm package, so IMO we need to host it somewhere and also archive it on npmjs as well (if possible)