Skip to content

Say that remember-me records no last-used stamp - #117

Merged
harikt merged 1 commit into
6.xfrom
docs-remember-me-last-used
Jul 25, 2026
Merged

Say that remember-me records no last-used stamp#117
harikt merged 1 commit into
6.xfrom
docs-remember-me-last-used

Conversation

@harikt

@harikt harikt commented Jul 25, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Documentation
    • Clarified that remember-me token storage does not retain issuance or last-used timestamps.
    • Explained that expiration advances during token renewal and should not be treated as a true last-used time.
    • Added guidance for implementing device tracking or lost-device detection with additional timestamp fields.

@harikt
harikt merged commit 1206139 into 6.x Jul 25, 2026
14 of 16 checks passed
@harikt
harikt deleted the docs-remember-me-last-used branch July 25, 2026 11:20
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8fff870e-79e1-4dd3-a134-4742f5b5e2db

📥 Commits

Reviewing files that changed from the base of the PR and between eb37eb3 and 0330383.

📒 Files selected for processing (1)
  • docs/remember-me.md

Walkthrough

The remember-me documentation now clarifies PDO token timestamp semantics and explains how to extend PdoRememberStorage with additional columns and timestamps.

Changes

Remember-me storage documentation

Layer / File(s) Summary
Document token timestamp semantics
docs/remember-me.md
The Token Storage section documents the absence of created_at and last_used_at, explains expires updates during validator rotation, and describes extending create() and update() for additional tracking fields.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • auraphp/Aura.Auth#107: Introduced the PDO remember-me storage whose field semantics are clarified here.

Poem

A bunny reads the token scroll,
No “last used” stamp adorns its role.
expires hops when validators spin,
New fields track each device in.
Documentation now tells the tale—
With carrots packed, the notes prevail!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs-remember-me-last-used

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant