Skip to content

fix(review): keep the file tooltip off the list it describes #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asnunes merged 1 commit into from
Sep 28, 2026
Merged

fix(review): keep the file tooltip off the list it describes #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions web/src/review/FileRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ export function FileRow({
}: FileRowProps) {
return (
<li>
<Tooltip>
{/* Not hoverable: moving up to the row above passed through a tooltip
that stayed open to be hovered, and the click landed on it. */}
<Tooltip disableHoverableContent>
<TooltipTrigger asChild>
<Button
variant="ghost"
Expand Down Expand Up @@ -89,7 +91,9 @@ export function FileRow({
{/* A real tooltip rather than `title`: the browser's own waits a second,
never opens on keyboard focus, and would drop the skim reason that
used to be the only thing it carried. */}
<TooltipContent className="max-w-[28rem]">
{/* To the right, over the diff, and never over the list: above the
row it covered the neighbour the reader was reaching for. */}
<TooltipContent side="right" sideOffset={8} className="max-w-[28rem]">
<div className="font-mono text-[0.6875rem]">{file.path}</div>
{file.skimReason && <div className="font-sans opacity-80">{file.skimReason}</div>}
{/* The button is labelled with the path, which is what a screen
Expand Down
Loading