Skip to content

fix(review): keep the file tooltip off the list it describes - #57

Merged
asnunes merged 1 commit into
mainfrom
fix/sidebar-tooltip-in-the-way
Sep 28, 2026
Merged

asnunes merged 1 commit into
mainfrom
fix/sidebar-tooltip-in-the-way

Conversation

@asnunes

@asnunes asnunes commented Sep 28, 2026

Copy link
Copy Markdown
Owner

Reported: it is hard to click a file in the sidebar, because the tooltip gets in the way on hover.

What was wrong

A file row's tooltip opened with no delay, above the row, which puts it right over the row before it. Radix tooltips are also hoverable by default: moving the pointer into the tooltip keeps it open. So a reader heading for the file above passed through the tooltip on the way, it stayed put, and the click landed on the tooltip instead of on the file.

What it does now

  • side="right": the tooltip opens beside the row, over the diff, so it never covers another file in the list.
  • disableHoverableContent: the tooltip closes as soon as the pointer leaves the row, so passing over it does not hold it open.

Testing

  • Checked in Chrome against a throwaway repository: hovered one row, took a screenshot to confirm the tooltip opens to the right, then moved up to the row above and clicked it. The click selected that file.
  • No automated test covers this: jsdom does not lay out, so it cannot tell where a tooltip lands.
  • vitest passes except light and dark > puts the choice on the root element. It fails the same way on main: under Node 26 the global localStorage is undefined in tests.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 28, 2026 21:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@asnunes
asnunes merged commit dcfc743 into main Sep 28, 2026
2 checks passed
@asnunes
asnunes deleted the fix/sidebar-tooltip-in-the-way branch September 28, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants