Repository navigation
Do not re-propose a health fix while its PR is open - #58
Merged
Merged
Conversation
A done health_fix has an open PR waiting for a maintainer merge. The finding persists until that merge, so later generations filed duplicates (live: P-0014/P-0015 duplicating P-0011/P-0012). Suppress while the recorded PR is open and unmerged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A finished health_fix is no longer re-proposed while the pull request it opened is still waiting for a maintainer merge.
Root cause
A health_fix proposal closes as
donewhen its PR opens. The finding (for example a missing README) only clears when a maintainer merges that PR. Until then every later generation saw the same finding, found the previous proposaldone, and filed a fresh duplicate.Seen live on 2026-10-13: P-0011 and P-0012 opened README PRs, and the next run filed P-0014 and P-0015 for the identical findings. Those duplicates are held in the tracker, but the engine should never have created them.
Changes
ion/propose/engine.py: in the done/failed branch, a health_fix whose recordedpr_numberis still open (and unmerged) is suppressed, with the candidate state naming the PR. An unreadable PR never suppresses a finding. Once the PR is merged or closed, later generations may propose again as before.tests/test_propose.py: the duplicate is reproduced first (two health proposals where one should stand), then the suppression and the re-propose-after-merge path are pinned.Validation
tests/test_propose.pyafter