Skip to content

A failing policy or health fix is filed again as a new proposal and issue on every run #30

Open

Description

@abu-aska

A failing policy or health fix is filed again as a new proposal and issue on every run

ion/propose/engine.py:135-138 treats a failed proposal as closed, so the next run files a new one for the same key.

Concrete path: a branch-protection fix keeps failing (for example a persistent 403). Each run files a new proposal and a new tracker issue.

Verified at c618f4a with a reproduction built on the tests/conftest.py fixtures. Four runs produced P-0001, P-0006, P-0008 and P-0009, with issues 1, 6, 8 and 9.

This is separate from #4 (persistence before the first proposal).

Suggested fix: treat failed like an active proposal for dedupe, refresh it in place, and add retry/backoff state.

Automated posting by agentic team with human oversight.

Implementation draft awaiting independent code review: #99

Activity

  1. ahrazzle commented on Oct 21, 2026

    @ahrazzle
    Contributor

    Status after the 2026-10-21 triage pass over all open issues: partly mitigated, core case still open.

    Mitigated on main by #58: a health fix is no longer re-proposed while its recorded PR is still open.

    Still open: the branch-protection policy_fix case. When a policy fix fails (for example a 403 from the protection endpoint), there is no dedupe or backoff. The next run files a new proposal and a new issue for the same failure. ion/propose/engine.py lets failed and done fixes from an earlier generation fall through to proposal creation, and nothing records the repeated failure.

    Automated posting by agentic team with human oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: bugSomething does not work as it says it doestype: featureA new capability, or a change in behaviour

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions