🛡️ Sentinel: [MEDIUM] Add timeouts to external fetch calls to prevent server resource exhaustion

.jules/sentinel.md

@@ -12,3 +12,7 @@
 **Vulnerability:** XSS risk via unsanitized `<` characters in `JSON.stringify` output injected into `<script type="application/ld+json">`.
 **Learning:** `JSON.stringify()` does not automatically escape `<` as `\u003c`. If dynamic or unsanitized content is serialized into a `<script>` tag via `dangerouslySetInnerHTML`, an attacker can include `</script>` to break out of the context and inject malicious scripts.
 **Prevention:** Always replace `<` with `\u003c` when injecting JSON output into script tags, e.g., `JSON.stringify(data).replace(/</g, '\\u003c')`.
+## 2025-06-06 - Missing Fetch Timeouts
+**Vulnerability:** External `fetch` calls without timeouts could lead to server resource exhaustion and Denial of Service (DoS) due to hanging connections.
+**Learning:** The native `fetch` API lacks a default timeout, leaving applications vulnerable if external APIs respond slowly or become unresponsive.
+**Prevention:** Always add an explicit timeout using `signal: AbortSignal.timeout(TIMEOUT_MS)` to all external `fetch` calls.

package.json

@@ -27,7 +27,7 @@
     "@types/node": "^20",
     "@types/react": "^19",
     "@types/react-dom": "^19",
-    "eslint": "^9",
+    "eslint": "^9.39.4",
     "eslint-config-next": "16.2.5",
     "github-slugger": "^2.0.0",
     "mdast-util-to-string": "^4.0.0",

scripts/sync-sources.mjs

@@ -22,6 +22,7 @@ const SOURCE_REPO_ORDER = ["hypersnap", "hypersnap-docs-web", "snap", "protocol"
 
 const DOCS_LINK_LIMIT = 80;
 const README_HEADING_LIMIT = 10;
+const FETCH_TIMEOUT_MS = 15000;
 
 const githubToken = process.env.GITHUB_TOKEN || process.env.GH_TOKEN;
 
@@ -32,6 +33,7 @@ async function fetchGithubJson(url, { optional = false } = {}) {
       "X-GitHub-Api-Version": "2022-11-28",
       ...(githubToken ? { Authorization: `Bearer ${githubToken}` } : {}),
     },
+    signal: AbortSignal.timeout(FETCH_TIMEOUT_MS),
   });
 
   if ((response.status === 404 || response.status === 409) && optional) {
@@ -53,6 +55,7 @@ async function fetchGithubText(url, { optional = false } = {}) {
       "X-GitHub-Api-Version": "2022-11-28",
       ...(githubToken ? { Authorization: `Bearer ${githubToken}` } : {}),
     },
+    signal: AbortSignal.timeout(FETCH_TIMEOUT_MS),
   });
 
   if ((response.status === 404 || response.status === 409) && optional) {

src/lib/network.ts

@@ -85,6 +85,7 @@ export async function getNetworkStatus(): Promise<NetworkStatus> {
       headers: {
         Accept: "application/json",
       },
+      signal: AbortSignal.timeout(NODE_PROBE_TIMEOUT_MS),
     });
 
     if (!response.ok) {

src/lib/snap-market.ts

@@ -1,6 +1,7 @@
 import { SNAP, correctedSnapFdv } from "@/lib/snap";
 
 export const SNAP_MARKET_REVALIDATE = 30;
+const MARKET_DATA_TIMEOUT_MS = 10_000;
 
 type DexPeriod = {
   buys?: number;
@@ -79,6 +80,7 @@ export async function getSnapMarketData(): Promise<SnapMarketResponse> {
         "user-agent": "hypersnap.org market data checker",
       },
       next: { revalidate: SNAP_MARKET_REVALIDATE },
+      signal: AbortSignal.timeout(MARKET_DATA_TIMEOUT_MS),
     });
 
     if (!response.ok) {