π‘οΈ Sentinel: [MEDIUM] Add timeouts to external fetch calls to prevent server resource exhaustion - #43
Conversation
This commit adds `AbortSignal.timeout()` to the `fetch` calls in `network.ts`, `snap-market.ts`, and `sync-sources.mjs` to prevent server resource exhaustion caused by hanging external connections. Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
CodeAnt AI is reviewing your PR. |
Thanks for using CodeAnt! πWe're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X Β· |
|
CodeAnt AI finished reviewing your PR. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
β Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 43e213a. Configure here.
| "X-GitHub-Api-Version": "2022-11-28", | ||
| ...(githubToken ? { Authorization: `Bearer ${githubToken}` } : {}), | ||
| }, | ||
| signal: AbortSignal.timeout(FETCH_TIMEOUT_MS), |
There was a problem hiding this comment.
Optional GitHub fetches abort sync
Medium Severity
Adding AbortSignal.timeout to fetchGithubJson and fetchGithubText makes timeouts throw before optional handling runs. Callers that pass optional: true only degrade on HTTP 404/409; a slow optional doc, tree, or release fetch now fails the entire sync-sources run instead of continuing with empty or partial data like missing resources do.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 43e213a. Configure here.
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43e213a423
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "user-agent": "hypersnap.org market data checker", | ||
| }, | ||
| next: { revalidate: SNAP_MARKET_REVALIDATE }, | ||
| signal: AbortSignal.timeout(MARKET_DATA_TIMEOUT_MS), |
There was a problem hiding this comment.
Add a timeout that survives revalidation
After this request has a cached response and the 30s next.revalidate interval expires, Next performs the refresh as a stale revalidation; in Next 16.2.5 the patched fetch intentionally omits init.signal for stale revalidations before calling the origin. This new AbortSignal.timeout therefore only covers cold cache misses, while the production background refresh to Dexscreener can still hang indefinitely and keep the pending revalidation/socket around. Use a timeout path that survives revalidation, or opt out of Next's fetch cache, before relying on this as the DoS mitigation.
Useful? React with πΒ / π.


User description
π¨ Severity: MEDIUM
π‘ Vulnerability: External
fetchcalls lacked explicit timeouts. The nativefetchAPI does not have a default timeout.π― Impact: Without a timeout, a hanging connection to an external API can cause server resource exhaustion and eventually a Denial of Service (DoS).
π§ Fix: Added
signal: AbortSignal.timeout(TIMEOUT_MS)to externalfetchcalls insrc/lib/network.ts,src/lib/snap-market.ts, andscripts/sync-sources.mjs.β Verification: Ran
npm run lint,npm run typecheck, andnpm run buildsuccessfully. Confirmed changes passed the Sentinel checklist criteria for a security enhancement.PR created automatically by Jules for task 4531735376751732223 started by @felirami
Note
Low Risk
Defensive timeouts on existing fetch paths with existing try/catch error handling; no auth or data-model changes.
Overview
Adds
AbortSignal.timeoutto outboundfetchcalls so slow or stuck third-party APIs cannot hold connections open indefinitely.scripts/sync-sources.mjsuses a 15s cap on GitHub JSON and raw text helpers.getNetworkStatusinsrc/lib/network.tsnow uses the existing 10s node probe timeout (aligned with other node health checks).getSnapMarketDatainsrc/lib/snap-market.tsaborts Dexscreener requests after 10s.Documents the pattern in
.jules/sentinel.md.eslintis pinned to^9.39.4inpackage.json/ lockfile.Reviewed by Cursor Bugbot for commit 43e213a. Bugbot is set up for automated code reviews on this repo. Configure here.
CodeAnt-AI Description
Add timeouts to external requests to avoid stuck connections
What Changed
Impact
β Fewer server hangs from slow external APIsβ Lower risk of resource exhaustion during network checksβ Faster recovery when GitHub or market data requests stallπ‘ Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Note
Add 15s timeouts to external fetch calls in sync scripts and runtime network probes
AbortSignal.timeout()to GitHub API fetches inscripts/sync-sources.mjswith a 15s timeout (FETCH_TIMEOUT_MS = 15000).src/lib/network.tsusing the existingNODE_PROBE_TIMEOUT_MSconstant.MARKET_DATA_TIMEOUT_MS = 10_000) to the dexscreener API fetch insrc/lib/snap-market.ts.AbortError, which routes into existing error handling paths and returnsok: falsewhere applicable.Macroscope summarized 43e213a.