fix(config): accept text/plain content-type in JsonResponseParser#90
Merged
Merged
Conversation
3 tasks
Contributor
|
Hi! A new PR-validation CI workflow recently landed on |
Some Solr request handlers (notably `/admin/ping` and certain standalone-mode paths) return JSON-encoded bodies with a `Content-Type: text/plain` header. SolrJ validates the response Content-Type against the set advertised by the configured `ResponseParser` and fails otherwise-valid responses with "Expected mime type in [application/json] but got text/plain", which surfaces through MCP tools such as `check-health` and `search` as errors even though the payload is a correct Solr JSON response. Widen `JsonResponseParser#getContentTypes()` to advertise both `application/json` and `text/plain` so these responses are parsed normally. No behavioural change for handlers that return `application/json`. Adds `JsonResponseParserContentTypesTest` pinning the advertised set. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Yunus Emre Korkmaz <yunus.emre.korkmaz@turboard.com>
dolphinium
force-pushed
the
fix/json-parser-text-plain
branch
from
4329f76 to
354ed00
Compare
Contributor
Author
|
@adityamparikh Rebased both branches(#89 and #90) onto current main — conflicts resolved and ci.yml is now triggering (currently action_required). Could you approve the workflow runs? Thanks! |
Contributor
|
Looks good to me. @epugh can you please merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Widens
JsonResponseParser#getContentTypes()to advertise bothapplication/jsonandtext/plain, so SolrJ stops rejecting otherwise-valid JSON responses that are served withContent-Type: text/plain.Motivation
Some Solr request handlers (notably
/admin/pingand a number of standalone-mode paths) return JSON-encoded bodies withContent-Type: text/plain. SolrJ validates the response Content-Type against the set advertised by the configuredResponseParserand fails with:…even though the payload is a valid Solr JSON response. This surfaces to MCP clients through tools like
check-healthandsearchas errors, despite the underlying query succeeding.Observed end-to-end against a real standalone Solr 9.x instance:
check-healthandsearchboth return the error above pre-fix, and return clean results post-fix.Changes
JsonResponseParser#getContentTypes: advertiseapplication/jsonandtext/plain.application/json.Tests
JsonResponseParserContentTypesTest(new): pins the advertised Content-Type set../gradlew buildpasses locally (Spotless + NullAway + full unit suite).Test plan
./gradlew spotlessCheck./gradlew build(unit tests)check-healthandsearchnow succeed on handlers that previously returnedtext/plain.Notes
CONTRIBUTING.md.Companion PR for the Basic Auth feature: #89
Co-authored-by: Claude noreply@anthropic.com