feat(config): support HTTP Basic Authentication credentials#89
Merged
Conversation
Contributor
|
If you can split it that would be awesome!!! |
dolphinium
force-pushed
the
feat/basic-auth-support
branch
from
3347b2f to
6e0ee41
Compare
dolphinium
changed the title
3 tasks
Contributor
Author
|
hi @epugh, I separated features as you requested. so happy to contribute to this project. have a great day. |
Contributor
|
Hi! A new PR-validation CI workflow recently landed on |
Add optional `solr.username` / `solr.password` configuration properties (also bound from the `SOLR_USERNAME` / `SOLR_PASSWORD` environment variables) that, when both are set, are applied to every SolrJ request via `HttpJdkSolrClient.Builder#withBasicAuthCredentials`. When either value is missing or the username is blank, the client is built without credentials so existing unauthenticated deployments are unaffected. Documents the new variables in the Development and Architecture guides and adds `SolrConfigAuthTest` covering: - no credentials attached when both values are missing, - no credentials attached when only one value is provided (or the username is blank), and - credentials applied when both values are provided. The existing `SolrConfigUrlNormalizationTest` is updated to the new record constructor. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Yunus Emre Korkmaz <yunus.emre.korkmaz@turboard.com>
dolphinium
force-pushed
the
feat/basic-auth-support
branch
from
c266d19 to
c3d03bf
Compare
Contributor
|
Thanks for this, @dolphinium! I took your feature commit unchanged and opened #152 on top of it, folding in a small review-cleanup pass (reuse Whether to continue here or land via #152 is up to the maintainers — just wanted to link the two so the connection is visible from both sides. |
epugh
added a commit
that referenced
this pull request
Jun 15, 2026
…152) * feat(config): support HTTP Basic Authentication credentials Add optional `solr.username` / `solr.password` configuration properties (also bound from the `SOLR_USERNAME` / `SOLR_PASSWORD` environment variables) that, when both are set, are applied to every SolrJ request via `HttpJdkSolrClient.Builder#withBasicAuthCredentials`. When either value is missing or the username is blank, the client is built without credentials so existing unauthenticated deployments are unaffected. Documents the new variables in the Development and Architecture guides and adds `SolrConfigAuthTest` covering: - no credentials attached when both values are missing, - no credentials attached when only one value is provided (or the username is blank), and - credentials applied when both values are provided. The existing `SolrConfigUrlNormalizationTest` is updated to the new record constructor. Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Yunus Emre Korkmaz <yunus.emre.korkmaz@turboard.com> * refactor(config): reuse Spring StringUtils/ReflectionUtils in basic-auth wiring Review cleanup on top of the HTTP Basic Auth support from #89 (by @dolphinium). No behavioural change to the feature. - SolrConfig: replace the inline `username != null && !username.isEmpty()` guard with Spring's `StringUtils.hasText`, matching the convention already used in HttpSecurityConfiguration and SearchService. - SolrConfigAuthTest: drop the hand-rolled superclass-walking `findField` helper in favour of `ReflectionUtils.findField`/`makeAccessible`/`getField`, and tighten the over-defensive `equals(x) || equals("Basic " + x)` assertion to an exact `assertEquals` now that the stored format is known (SolrJ stores `"Basic " + Base64(user:pass)` in UTF-8). ./gradlew build passes (Spotless + NullAway + full test suite incl. Testcontainers). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com> --------- Signed-off-by: Yunus Emre Korkmaz <yunus.emre.korkmaz@turboard.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com> Co-authored-by: Yunus Emre Korkmaz <yunus.emre.korkmaz@turboard.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Eric Pugh <epugh@opensourceconnections.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional HTTP Basic Authentication for the SolrJ client.
solr.username/solr.password(bound fromSOLR_USERNAME/SOLR_PASSWORDenv vars).HttpJdkSolrClient.Builder#withBasicAuthCredentials.Motivation
Tested end-to-end against a production Basic-auth-protected Solr reached through an SSH tunnel. Before this PR every tool call returned
401 require authentication.Changes
SolrConfigurationProperties: add nullableusernameandpasswordrecord components (JSpecify@Nullable); expanded JavaDoc.SolrConfig#solrClient: applywithBasicAuthCredentialswhen both credentials are present and the username is non-blank.dev-docs/ARCHITECTURE.mdanddev-docs/DEVELOPMENT.mdlist the two new env vars next toSOLR_URL.Tests
SolrConfigAuthTest(new): 5 parameterized cases covering none / username-only / password-only / blank-username / both — asserts via reflection onHttpSolrClientBase#basicAuthAuthorizationStr.SolrConfigUrlNormalizationTest: updated to the new record constructor../gradlew buildpasses locally (Spotless + NullAway + full unit suite).Test plan
./gradlew spotlessCheck./gradlew build(unit tests)Notes
CONTRIBUTING.md.Companion PR (Content-Type tolerance fix): #90
Co-authored-by: Claude noreply@anthropic.com