Remove Super-Linter action and move flake8 to pre-commit

[jbampton]

Description

This PR removes the Super-Linter action which was running flake8 and moves this check to pre-commit.

We are running an older version of the GitHub Super-Linter which should be updated.

So we can now run flake8 locally with pre-commit to speed up review time. Finding issues on our local machine first instead of waiting for the Super-Linter action to finish when opening a pr.

Also the GitHub Actions policy of the ASF says:

"You MAY use all actions internal to the apache/, github/ and actions/* namespaces without restrictions."

https://infra.apache.org/github-actions-policy.html

Since the most current version of the Super-Linter is no longer under "github/*" we need to remove this action.

"NOTICE: If your use of the super-linter action failed around April 26th, 2023, we changed the organization name from github to super-linter so you will need to update your references to this action from github/super-linter to super-linter/super-linter."

https://github.com/super-linter/super-linter

https://flake8.pycqa.org/en/latest/user/using-hooks.html

https://github.com/PyCQA/flake8

When run locally with pre-commit the flake8 check found some Python files which had issues which I have ignored and these can be cleaned up or processed later if needed.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Run all pre-commit checks with:

pre-commit run --all-files

Just test flake8:

pre-commit run flake8 --all-files

[codecov]

Codecov Report

Merging #7861 (e16d3b8) into main (0204377) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7861      +/-   ##
============================================
- Coverage     14.38%   14.38%   -0.01%     
+ Complexity    10074    10072       -2     
============================================
  Files          2747     2747              
  Lines        258922   258922              
  Branches      40318    40318              
============================================
- Hits          37246    37242       -4     
+ Misses       216867   216866       -1     
- Partials       4809     4814       +5     

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jbampton]

@blueorangutan package

[blueorangutan]

@jbampton a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6759