Enable four more flake8 rules#7811
Merged
Merged
Conversation
DaanHoogland
approved these changes
Aug 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #7811 +/- ##
=========================================
Coverage 14.38% 14.39%
- Complexity 10078 10081 +3
=========================================
Files 2748 2748
Lines 258975 258975
Branches 40329 40329
=========================================
+ Hits 37261 37271 +10
+ Misses 216898 216890 -8
+ Partials 4816 4814 -2 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
From the repo root you can test locally with: `flake8 --config=.github/linters/.flake8 .` https://www.flake8rules.com/ https://flake8.pycqa.org/en/latest/user/configuration.html#configuring-flake8 The Python code was already following these "rules" so we just need to enforce them to stop regressions.
DaanHoogland
force-pushed
the
enable-more-flake8-rules
branch
from
475b64a to
b9206f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.flake8rules.com/
https://flake8.pycqa.org/en/latest/user/configuration.html#configuring-flake8
The Python code was already following these "rules" so we just need to enforce them to stop regressions.
Description
This PR adds four more flake8 rules to our testing with pre-commit
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
After #7861 was merged
flake8now runs withpre-commit.You can now test locally with:
pre-commit run flake8 --all-files