Skip to content

Display VPC name to which the network belongs to#4483

Merged
yadvr merged 2 commits into
apache:masterfrom
ravening:vpcname-network-response
Nov 20, 2020
Merged

Display VPC name to which the network belongs to#4483
yadvr merged 2 commits into
apache:masterfrom
ravening:vpcname-network-response

Conversation

@ravening

Copy link
Copy Markdown
Member

Description

If an isolated network is created in VPC then display
its name along with vpc id which is used for UI

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Cloudmonkey result

(local) mgt01 > list networks filter=name,vpcid,vpcname
{
  "count": 3,
  "network": [
    {
      "name": "vpctier",
      "vpcid": "d0ad3be2-9ab0-4f96-a863-2776eeb4f267",
      "vpcname": "testvpc"
    },
    {
      "name": "tier1",
      "vpcid": "e49be49b-bd22-4071-89b0-c13cfb7f29d0",
      "vpcname": "vpc1"
    },
    {
      "name": "test"
    }
  ]
}

If an isolated network is created in VPC then display
its name along with vpc id which is used for UI
Comment thread api/src/main/java/org/apache/cloudstack/api/response/NetworkResponse.java Outdated

@davidjumani davidjumani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a minor doc suggestion

@yadvr yadvr added this to the 4.15.0.0 milestone Nov 20, 2020

@yadvr yadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, simple setter

@yadvr

yadvr commented Nov 20, 2020

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr

yadvr commented Nov 20, 2020

Copy link
Copy Markdown
Member

Explicit smoketest not necessary but let's at least wait for Travis and packaging to pass

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2419

@yadvr yadvr merged commit 0a2a54a into apache:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants