Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

Display network type in network overview#845

Merged
yadvr merged 2 commits into
apache:masterfrom
ravening:network-type
Nov 23, 2020
Merged

Display network type in network overview#845
yadvr merged 2 commits into
apache:masterfrom
ravening:network-type

Conversation

@ravening

@ravening ravening commented Nov 4, 2020

Copy link
Copy Markdown
Member

Display "VPC Tier" as type if an isolated network belongs to VPC
else display its regular type

Screenshot 2020-11-19 at 16 35 16

Backend changes are in apache/cloudstack#4483

@yadvr yadvr added this to the 1.0-GA milestone Nov 4, 2020
Comment thread src/config/section/network.js Outdated
@yadvr

yadvr commented Nov 5, 2020

Copy link
Copy Markdown
Member

For now, moved to 1.1 as this is not a blocker or critical issue.

@yadvr yadvr modified the milestones: 1.0-GA, 1.1 Nov 5, 2020
Rakesh Venkatesh added 2 commits November 19, 2020 15:44
Display "VPC Tier" as type if an isolated network belongs to VPC
else display its regular type
@ravening

ravening commented Nov 19, 2020

Copy link
Copy Markdown
Member Author

@rhtyd @GabrielBrascher I made changes to display vpcname in a new coloumn with a router link to it.
I also made changes to display the domain name as well

Also note that this depends on backend change for which I have created the PR

@davidjumani davidjumani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ravening could you add a backward compatibility check similar to https://github.com/apache/cloudstack-primate/blob/master/src/config/section/infra/secondaryStorages.js#L27 if the backend changes don't get into 4.15 ?

@davidjumani

Copy link
Copy Markdown
Contributor

Backend changes merged. Moving to 1.0

@davidjumani davidjumani modified the milestones: 1.1, 1.0-GA Nov 23, 2020
@yadvr yadvr merged commit ab9eaed into apache:master Nov 23, 2020
@yadvr

yadvr commented Nov 23, 2020

Copy link
Copy Markdown
Member

@davidjumani merging this as Primate 1.0 has become too much dependent on 4.15 (esp. the VM deployment form) and we should encourage backward compatibility from 4.15 onwards. The backend PR will make into 4.15.
@ravening any separate PR to address David's concern is welcome!

weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
* Display network type in network overview

Display "VPC Tier" as type if an isolated network belongs to VPC
else display its regular type

* Display vpc name with router link

Co-authored-by: Rakesh Venkatesh <r.venkatesh@global.leaseweb.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants