Skip to content

Adding public ip to listKubernetesClusterResponse#4414

Merged
DaanHoogland merged 1 commit into
apache:masterfrom
shapeblue:add-cks-ip
Oct 28, 2020
Merged

Adding public ip to listKubernetesClusterResponse#4414
DaanHoogland merged 1 commit into
apache:masterfrom
shapeblue:add-cks-ip

Conversation

@davidjumani

@davidjumani davidjumani commented Oct 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adding public ip to listKubernetesClusterResponse to make life easier as well as enhance the UI

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

(localcloud) SBCM5> > list kubernetesclusters 
{
  "count": 1,
  "kubernetescluster": [
    {
      ..........
      "ipaddress": "10.1.36.3",
      "ipaddressid": "a961de46-6a77-4e20-b078-2870853286a2",
     ..........
    }
  ]
}

@davidjumani

davidjumani commented Oct 20, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented Oct 20, 2020

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@davidjumani davidjumani mentioned this pull request Oct 20, 2020
Merged
@davidjumani davidjumani marked this pull request as ready for review October 20, 2020 12:32
@davidjumani

davidjumani commented Oct 20, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented Oct 20, 2020

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Oct 20, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2220

@davidjumani davidjumani changed the base branch from 4.14 to master October 20, 2020 12:59
@davidjumani

davidjumani commented Oct 20, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@davidjumani davidjumani added this to the 4.15.0.0 milestone Oct 20, 2020
@blueorangutan

blueorangutan commented Oct 20, 2020

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Oct 20, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2231

@blueorangutan

blueorangutan commented Oct 20, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2232

@davidjumani

davidjumani commented Oct 20, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

blueorangutan commented Oct 20, 2020

Copy link
Copy Markdown

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Oct 21, 2020

Copy link
Copy Markdown

Trillian test result (tid-3026)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30246 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4414-t3026-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

DaanHoogland
DaanHoogland approved these changes Oct 21, 2020
View reviewed changes
Comment thread ...ernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java
response.setEndpoint(kubernetesCluster.getEndpoint());
response.setNetworkId(ntwk.getUuid());
response.setAssociatedNetworkName(ntwk.getName());
if (ntwk.getGuestType() == Network.GuestType.Isolated) {

@DaanHoogland DaanHoogland Oct 21, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so when SHARED/L2/VPC this needs changing again?

@davidjumani davidjumani Oct 21, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be any need. It doesn't support L2 / Shared (since they don't have public IPs) or VPCs as of now, and if support is added, VPC networks are again isolated networks

shwstppr
shwstppr approved these changes Oct 27, 2020
View reviewed changes

@shwstppr shwstppr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland DaanHoogland reopened this Oct 27, 2020
@davidjumani

davidjumani commented Oct 27, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

blueorangutan commented Oct 27, 2020

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Oct 27, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2281

@davidjumani

davidjumani commented Oct 27, 2020

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

blueorangutan commented Oct 27, 2020

Copy link
Copy Markdown

@davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Oct 28, 2020

Copy link
Copy Markdown

Trillian test result (tid-3083)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33209 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4414-t3083-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit 2627258 into apache:master Oct 28, 2020
@DaanHoogland DaanHoogland deleted the add-cks-ip branch October 28, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes
@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

type:enhancement

Projects

None yet

Milestone

4.15.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@davidjumani @blueorangutan @shwstppr @DaanHoogland