This repository was archived by the owner on Jan 20, 2021. It is now read-only.
infocard: Adding support to redirect to publicip#812
Merged
Conversation
davidjumani
force-pushed
the
add-redirect-ip
branch
from
0bab923 to
90f02f2
Compare
Contributor
Author
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
yadvr
reviewed
Oct 20, 2020
| @click="$message.success(`${$t('label.copied.clipboard')} : ${ ipaddress }`)" | ||
| v-clipboard:copy="ipaddress" /> | ||
| <span>{{ ipaddress }}</span> | ||
| <router-link v-if="resource.ipaddressid" :to="{ path: '/publicip/' + resource.ipaddressid }">{{ ipaddress }}</router-link> |
Member
There was a problem hiding this comment.
We need to check if ip address is always public IP address?
Contributor
Author
There was a problem hiding this comment.
Don't think that'll be needed since only public IPs will have an id associated with it
Member
There was a problem hiding this comment.
I'll need to do some checks before merging
yadvr
approved these changes
Oct 28, 2020
Member
|
I checked few views where this lgtm, but it could add regression for few possible places if ipaddress is not returned just ipadddressid |
weizhouapache
pushed a commit
that referenced
this pull request
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support to redirect to publicip. Works with cks clusters after apache/cloudstack#4414