Skip to content

Run portable ValidatesRunner tests one at a time - #40632

Open
aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:flink-pvr-one-thread
Open

aIbrahiim wants to merge 1 commit into
apache:masterfrom
aIbrahiim:flink-pvr-one-thread

Conversation

@aIbrahiim

@aIbrahiim aIbrahiim commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

fixes: #38934
caused by: #40324
#38934 (comment)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR limits in-JVM test concurrency for Flink Portable ValidatesRunner tasks to 1 thread (beam.validatesRunner.parallelThreads=1), matching the existing configuration in the Spark job server. This resolves OOMs and test hangs caused by spawning up to 8 concurrent in-process job servers and Flink mini-clusters within a single 4GB test worker JVM.

🔍 General Feedback

  • The fix is clean, well-targeted, and directly addresses the resource contention introduced when beam.test.parallelThreads was defaulted to 8 in #40324 while preserving fork-level parallelism (maxParallelForks = 2).

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@Amar3tto
Amar3tto requested a review from Abacn October 16, 2026 12:31

@Abacn Abacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Abacn

Abacn commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

However it seems the test still stuck, probably other issues introduced since then

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@aIbrahiim

Copy link
Copy Markdown
Contributor Author

However it seems the test still stuck, probably other issues introduced since then

yeah the 1.20 job is the old DataSet suite and those 7 tests already hang on master until they hit the 20 min timeout but the other Flink versions passed. i excluded them for DataSet only so that job can actually finish

@Abacn Abacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm for now, however we still need to fix these tests as Flink 1.20 is LTS. Could you please open an Issue as a release block?

@Abacn

Abacn commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

actually it seems still stuck

@aIbrahiim
aIbrahiim force-pushed the flink-pvr-one-thread branch from 0f2c463 to f420fc9 Compare October 18, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PostCommit Java PVR Flink Batch job is flaky

2 participants