Repository navigation
Follow up fix fork comiple errors - #40620
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR cleanly restores the -source/-target replacement logic in setCompileAndRuntimeJavaVersion (along with a helpful comment explaining the Error Prone and Gradle #22747 constraint) while deduplicating javaHome fork configuration and removing the obsolete Java 8 branch in setJavaVerOptions.
🔍 General Feedback
- The changes are well-scoped, restore compatibility when forking
JavaCompiletasks to an external JDK, and improve readability inBeamModulePlugin.groovy.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
* Partly revert apache#40595: setCompileAndRuntimeJavaVersion logic wasn't stale it's needed to resolve errorprone x Gradle known issue compatibility * Clean up Java8 leftovers in setJavaVerOptions.
Abacn
force-pushed
the
errorprone-followup
branch
from
October 15, 2026 19:33
90f7112 to
0e8ab29
Compare
shunping
approved these changes
Oct 15, 2026
Contributor
Author
|
There are a few GCP IO integration tests permared: pubsub test failing due to an ongoing PubSub outage, not related to the change, merging for now |
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly revert Fix JmsIO finalize removal warning and clean up stale Java version logic #40595: setCompileAndRuntimeJavaVersion logic wasn't stale it's needed to resolve errorprone x Gradle known issue compatibility
Clean up Java8 leftovers in setJavaVerOptions.
Tested with both
./gradlew :sdks:java:io:jms:compileJavawith Java21, and./gradlew :sdks:java:io:jms:compileJava -Pjava21Home=<>with Java11