Repository navigation
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR partially reverts #40595 by restoring BeamModulePlugin.setCompileAndRuntimeJavaVersion to replace --release (as well as existing -source/-target flags) with -source <ver> -target <ver>, resolving compilation failures in beam_PreCommit_Java_IOs_Direct. It also adds the .github/trigger_files/beam_PreCommit_Java_IOs_Direct.json trigger file to run the workflow on this PR.
🔍 General Feedback
- The restored
setCompileAndRuntimeJavaVersionimplementation matches the pre-#40595 behavior and cleanly handles--release,-source, and-targetcompiler arguments in place. - The added workflow trigger file follows the standard convention used across
.github/trigger_files/.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Collaborator
Author
|
Let's go with your fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed workflow:
https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_IOs_Direct.yml