Skip to content

[yaml] - fix spanner configs and examples - #40587

Open
derrickaw wants to merge 1 commit into
apache:masterfrom
derrickaw:20261014_fixWriteToSpannerYaml
Open

derrickaw wants to merge 1 commit into
apache:masterfrom
derrickaw:20261014_fixWriteToSpannerYaml

Conversation

@derrickaw

@derrickaw derrickaw commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Problem: Current code has many uses and examples showing config parameters with a _id suffix, which is not correct.
Plan: remove _id suffix uses and update some naming

@derrickaw

Copy link
Copy Markdown
Collaborator Author

/gemini review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates the ReadFromSpanner and WriteToSpanner Beam YAML examples, unit test mocks, and Java SchemaTransformProvider descriptions to use the user-facing YAML configuration parameter names (project, instance, database, table) instead of the underlying Java configuration field names (project_id, instance_id, database_id, table_id).

🔍 General Feedback

  • All changes accurately reflect the renaming provider mappings defined for ReadFromSpanner and WriteToSpanner in sdks/python/apache_beam/yaml/standard_io.yaml and are consistent with the existing integration tests in sdks/python/apache_beam/yaml/extended_tests/databases/spanner.yaml.
  • No issues found; the changes look good to merge.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.93%. Comparing base (76f6e6d) to head (ba61f8d).
⚠️ Report is 168 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #40587       +/-   ##
=============================================
+ Coverage     56.16%   79.93%   +23.76%     
=============================================
  Files          1124      488      -636     
  Lines        178336    82347    -95989     
  Branches       1489        0     -1489     
=============================================
- Hits         100170    65823    -34347     
+ Misses        75645    16524    -59121     
+ Partials       2521        0     -2521     
Flag Coverage Δ
go ?
java ?
python 79.93% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw
derrickaw marked this pull request as ready for review October 14, 2026 17:52

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates the ReadFromSpanner and WriteToSpanner Beam YAML examples, unit test mocks, and Java SchemaTransformProvider descriptions to use the user-facing YAML configuration parameter names (project, instance, database, table) instead of the underlying Java configuration field names (project_id, instance_id, database_id, table_id). It also fixes a typo in SpannerWriteSchemaTransformProvider's description where ReadFromSpanner was mistakenly shown instead of WriteToSpanner.

🔍 General Feedback

  • All changes accurately reflect the renaming provider mappings defined for ReadFromSpanner and WriteToSpanner in sdks/python/apache_beam/yaml/standard_io.yaml.
  • No issues found; the changes look good to merge.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @chamikaramj for label yaml.
Backup reviewer: Abacn (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant