Repository navigation
Conversation
|
/gemini review |
There was a problem hiding this comment.
📋 Review Summary
This PR updates the ReadFromSpanner and WriteToSpanner Beam YAML examples, unit test mocks, and Java SchemaTransformProvider descriptions to use the user-facing YAML configuration parameter names (project, instance, database, table) instead of the underlying Java configuration field names (project_id, instance_id, database_id, table_id).
🔍 General Feedback
- All changes accurately reflect the
renamingprovider mappings defined forReadFromSpannerandWriteToSpannerinsdks/python/apache_beam/yaml/standard_io.yamland are consistent with the existing integration tests insdks/python/apache_beam/yaml/extended_tests/databases/spanner.yaml. - No issues found; the changes look good to merge.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40587 +/- ##
=============================================
+ Coverage 56.16% 79.93% +23.76%
=============================================
Files 1124 488 -636
Lines 178336 82347 -95989
Branches 1489 0 -1489
=============================================
- Hits 100170 65823 -34347
+ Misses 75645 16524 -59121
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
📋 Review Summary
This PR updates the ReadFromSpanner and WriteToSpanner Beam YAML examples, unit test mocks, and Java SchemaTransformProvider descriptions to use the user-facing YAML configuration parameter names (project, instance, database, table) instead of the underlying Java configuration field names (project_id, instance_id, database_id, table_id). It also fixes a typo in SpannerWriteSchemaTransformProvider's description where ReadFromSpanner was mistakenly shown instead of WriteToSpanner.
🔍 General Feedback
- All changes accurately reflect the renaming provider mappings defined for
ReadFromSpannerandWriteToSpannerinsdks/python/apache_beam/yaml/standard_io.yaml. - No issues found; the changes look good to merge.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Assigning reviewers: R: @chamikaramj for label yaml. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Problem: Current code has many uses and examples showing config parameters with a
_idsuffix, which is not correct.Plan: remove
_idsuffix uses and update some naming