Repository navigation
add a draft gemini review check - #40589
Conversation
|
Assigning reviewers: R: @damccorm for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
📋 Review Summary
This PR adds a pre-check step to the Gemini code review workflow to skip automatic reviews on the ready_for_review event if a Gemini review has already been posted on the PR (e.g., via /gemini review while in draft). The implementation cleanly reuses actions/github-script@v9 and properly gates the subsequent workflow steps.
🔍 General Feedback
- The pagination over
github.rest.pulls.listReviewsand matching againstgithub-actions[bot]and the/gemini reviewfooter signature accurately identifies prior reviews from this workflow. - The conditional
steps.check_draft_review.outputs.reviewed_in_draft != 'true'behaves as expected both whencheck_draft_reviewruns and when it is skipped on other trigger events.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Verification that it works - #40594 (comment) - thanks |
Problem: When opening a draft PR and the user happens to request a
/gemini reviewand then later on makes the PR ready for review, another gemini review occurs and possibly duplicates the previous findings, rebuttals etc. See #40587 for context.Plan: add a check to the gemini review workflow to prevent duplicate reviews when switching from draft to ready for review states.