Skip to content

perf(eio): remove Fiber.first from read loop #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anmonteiro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf(eio): remove Fiber.first from read loop #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions eio/gluten_eio.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,15 +87,7 @@ module IO_loop = struct
let read_closed, resolve_read_closed = read_closed
and write_closed = ref false in
let read_buffer = Buffer.create read_buffer_size in
let rec read_loop =
let read socket read_buffer =
Fiber.first
(fun () -> read socket read_buffer)
(fun () ->
Promise.await read_closed;
raise End_of_file)
in
fun () ->
let rec read_loop () =
let rec read_loop_step () =
match Runtime.next_read_operation t with
| `Read ->
Expand Down Expand Up @@ -242,7 +234,9 @@ module Client = struct
(fun () ->
let cancel_reader, resolve_cancel_reader = read_closed in
if not (Promise.is_resolved cancel_reader)
then Promise.resolve resolve_cancel_reader ())
then (
IO_loop.shutdown socket `Receive;
Promise.resolve resolve_cancel_reader ()))
; shutdown_complete = shutdown_p
}

Expand Down
Loading